Closed #427.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/427#event-1392092950
Squashed and pushed tp
[master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/889b34b9)
and
[2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/bf34887e).
Thanks @trevorflanagan!
--
You are receiving this because you are subscribed to this thread.
Reply to this ema
trevorflanagan commented on this pull request.
> }
@Provides
@Named(SERVER_STOPPED_PREDICATE)
@VisibleForTesting
public Predicate provideServerStoppedPredicate(final
DimensionDataCloudControlApi api,
final ComputeServiceConstants.Timeouts timeouts, final
Compute
@trevorflanagan pushed 1 commit.
349211f Refactor DimensionDataCloudControlResponseUtils waitFor* methods so
that they are injectable. PR Updates.
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/427/files/aef
nacx commented on this pull request.
Just one minor left. Thanks!
> }
@Provides
@Named(SERVER_STOPPED_PREDICATE)
@VisibleForTesting
public Predicate provideServerStoppedPredicate(final
DimensionDataCloudControlApi api,
final ComputeServiceConstants.Timeouts timeou
@trevorflanagan pushed 1 commit.
aef83ec Refactor DimensionDataCloudControlResponseUtils waitFor* methods so
that they are injectable. PR Updates.
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/427/files/b88
trevorflanagan commented on this pull request.
> + private final NetworkApi networkApi;
+
+ private NetworkDomainState(final NetworkApi networkApi, final State
state) {
+ this.networkApi = networkApi;
+ this.state = state;
+ }
+
+ @Override
+ public bool
nacx commented on this pull request.
Some small comments about the predicates and timeout configuration. Overall
looks good. hanks @trevorflanagan!
> + public static final String SERVER_STARTED_PREDICATE =
> "SERVER_STARTED_PREDICATE";
+ public static final String SERVER_STOPPED_PREDICATE =
trevorflanagan commented on this pull request.
> +import org.jclouds.dimensiondata.cloudcontrol.domain.NetworkDomain;
+import org.jclouds.dimensiondata.cloudcontrol.domain.Server;
+import org.jclouds.dimensiondata.cloudcontrol.domain.State;
+import org.jclouds.dimensiondata.cloudcontrol.domain.V
@nacx as requested I have done this piece of refactoring that was requested in
https://github.com/jclouds/jclouds-labs/pull/426 and
https://github.com/jclouds/jclouds-labs/pull/400#discussion_r127640050.
You can view, comment on, or merge this pull request online at:
https://github.com/jcloud
10 matches
Mail list logo
