sure thanks for double-checking it
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/436#issuecomment-391117526
> makes sense?
Yes, clear, thanks. Just wanted to make sure we weren't missing any code that
we were intending to add ;-)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@demobox I think guava21 updates are incidentally required as we updated
guava21 in jclouds/jclouds, so technically the PR doesn't bump guava version
for jclouds-labs in its pom.xml but it happens because of the upstream changes.
makes sense?
--
You are receiving this because you are
andreaturli commented on this pull request.
> @@ -40,7 +40,7 @@
import java.util.Properties;
import java.util.Set;
-import static
com.google.common.util.concurrent.MoreExecutors.sameThreadExecutor;
+import static
com.google.common.util.concurrent.MoreExecutors.newDirectExecutorService;
> bump guava version to 21.0
@andreaturli Just to clarify: is this part of this PR? I didn't see any code
change related to that, but it may have been removed or after an underlying
merge.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or
merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/1b5dd9fe)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/436#issuecomment-391017677
Closed #436.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/436#event-1639523209
cool, thanks @nacx and @gaul merging now
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/436#issuecomment-391014797
nacx approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/436#pullrequestreview-122199296
gaul approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/436#pullrequestreview-121802549
- bump guava version to 21.0
- fix DimensionData test
this is required for https://github.com/jclouds/jclouds/pull/1197
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/436
-- Commit Summary --
* Upgrade to java8
-- File Changes
11 matches
Mail list logo
