merged at
(master)[http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/89cb6f0f]
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/308#issuecomment-248317509
Closed #308.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/308#event-795734646
@andreaturli pushed 1 commit.
07007d9 refactor logback-test.xml
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/308/files/8f403aa5cc1c711496a670c3fbf3e03eadca969e..07007d994a33b1cc3c62a6294e8760141014758e
@andreaturli pushed 2 commits.
12f49f2 add parser module
8f403aa separate the DeploymentToVMDeployment to a function
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
nacx commented on this pull request.
> @@ -46,9 +44,9 @@ protected void bindErrorHandlers() {
@Override
protected void installLocations() {
super.installLocations();
- bind(ImplicitLocationSupplier.class).
-
nacx commented on this pull request.
> @@ -28,6 +30,7 @@ public static Properties defaultProperties(Properties
> properties) {
properties.put("oauth.credential", "password");
properties.put("oauth.endpoint",
"https://login.microsoftonline.com/oauth2/token;);
nacx commented on this pull request.
> -vmLocations.addAll(m.locations());
-break;
- }
- }
-
- Iterable result = Iterables.filter(locations, new
Predicate() {
- @Override
- public boolean apply(Location input) {
-return
andreaturli commented on this pull request.
> @@ -28,6 +30,7 @@ public static Properties defaultProperties(Properties
> properties) {
properties.put("oauth.credential", "password");
properties.put("oauth.endpoint",
"https://login.microsoftonline.com/oauth2/token;);
andreaturli commented on this pull request.
> @Inject
AzureComputeServiceAdapter(final AzureComputeApi api, final
AzureComputeConstants azureComputeConstants,
- CleanupResources cleanupResources) {
+ CleanupResources
nacx requested changes on this pull request.
Thanks @andreaturli! I've added the comments for the things that I think we
have to change.
> @Inject
AzureComputeServiceAdapter(final AzureComputeApi api, final
AzureComputeConstants azureComputeConstants,
-
> @@ -46,9 +44,9 @@ protected void bindErrorHandlers() {
> @Override
> protected void installLocations() {
>super.installLocations();
> - bind(ImplicitLocationSupplier.class).
> - to(OnlyLocationOrFirstRegionOptionallyMatchingRegionId.class).
I think
@andreaturli pushed 1 commit.
aaae684 revert ZONES to REGIONS
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/308/files/961db5c145342971726063e25776e0011ab8ed36..aaae68457526b198a2b30d7f648b4ef0b46ec359
> @@ -46,9 +44,9 @@ protected void bindErrorHandlers() {
> @Override
> protected void installLocations() {
>super.installLocations();
> - bind(ImplicitLocationSupplier.class).
> - to(OnlyLocationOrFirstRegionOptionallyMatchingRegionId.class).
@nacx I'm having
ok thanks, I guess this one confused me
https://github.com/jclouds/jclouds-labs/pull/308#issuecomment-239163128 :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
I don't think so. The last comments have not been addressed. We agreed that the
change form region to zone was not good, so all that stuff needs to be reverted.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@nacx good to merge?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/308#issuecomment-246959604
> @Inject
> AzureComputeServiceAdapter(final AzureComputeApi api, final
> AzureComputeConstants azureComputeConstants,
> - CleanupResources cleanupResources) {
> + CleanupResources cleanupResources,
> ProviderMetadata
> @Inject
> AzureComputeServiceAdapter(final AzureComputeApi api, final
> AzureComputeConstants azureComputeConstants,
> - CleanupResources cleanupResources) {
> + CleanupResources cleanupResources,
> ProviderMetadata
> @Inject
> AzureComputeServiceAdapter(final AzureComputeApi api, final
> AzureComputeConstants azureComputeConstants,
> - CleanupResources cleanupResources) {
> + CleanupResources cleanupResources,
> ProviderMetadata
> @@ -28,6 +30,7 @@ public static Properties defaultProperties(Properties
> properties) {
> properties.put("oauth.credential", "password");
> properties.put("oauth.endpoint",
> "https://login.microsoftonline.com/oauth2/token;);
> properties.put(CREDENTIAL_TYPE,
> @Inject
> AzureComputeServiceAdapter(final AzureComputeApi api, final
> AzureComputeConstants azureComputeConstants,
> - CleanupResources cleanupResources) {
> + CleanupResources cleanupResources,
> ProviderMetadata
> @Inject
> AzureComputeServiceAdapter(final AzureComputeApi api, final
> AzureComputeConstants azureComputeConstants,
> - CleanupResources cleanupResources) {
> + CleanupResources cleanupResources,
> ProviderMetadata
> @@ -28,6 +30,7 @@ public static Properties defaultProperties(Properties
> properties) {
> properties.put("oauth.credential", "password");
> properties.put("oauth.endpoint",
> "https://login.microsoftonline.com/oauth2/token;);
> properties.put(CREDENTIAL_TYPE,
> @@ -28,6 +30,7 @@ public static Properties defaultProperties(Properties
> properties) {
> properties.put("oauth.credential", "password");
> properties.put("oauth.endpoint",
> "https://login.microsoftonline.com/oauth2/token;);
> properties.put(CREDENTIAL_TYPE,
Thanks @andreaturli!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/308#issuecomment-239163128
> @@ -28,6 +30,7 @@ public static Properties defaultProperties(Properties
> properties) {
> properties.put("oauth.credential", "password");
> properties.put("oauth.endpoint",
> "https://login.microsoftonline.com/oauth2/token;);
> properties.put(CREDENTIAL_TYPE,
>
> import static com.google.common.base.Preconditions.checkNotNull;
> -import org.jclouds.logging.slf4j.config.SLF4JLoggingModule;
> -import org.jclouds.logging.config.LoggingModule;
> -
> +import static
> org.jclouds.azurecompute.arm.config.AzureComputeProperties.RESOURCE_GROUP_NAME;
>
> @@ -47,20 +47,14 @@
> @Override
> public org.jclouds.domain.Location apply(final Location location) {
>final LocationBuilder builder = new LocationBuilder();
> - String id = location.id();
> - int index = id.lastIndexOf('/');
> - if (index > 0 && (index + 1) <
> @Inject
> AzureComputeServiceAdapter(final AzureComputeApi api, final
> AzureComputeConstants azureComputeConstants,
> - CleanupResources cleanupResources) {
> + CleanupResources cleanupResources,
> ProviderMetadata
@andreaturli pushed 1 commit.
961db5c address initial comments from @nacx
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
- change location scope to ZONE vs REGION
- edit the README
- fix Region.byName
- add more Regions in Region class
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/308
-- Commit Summary --
* add support for whitelisting locations
31 matches
Mail list logo
