Re: [jclouds/jclouds-labs] pb-updates-v3 (#333)

2016-11-28 Thread Ignasi Barrera
HI @alibazlamit! I've opened [JCLOUDS-1207](https://issues.apache.org/jira/browse/JCLOUDS-1207) to track the promotion of profitbricks-rest. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-labs] pb-updates-v3 (#333)

2016-11-24 Thread alibazlamit
@nacx how are we going to proceed with this? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/333#issuecomment-262791295

Re: [jclouds/jclouds-labs] pb-updates-v3 (#333)

2016-11-23 Thread Ignasi Barrera
Having the live tests passing consistently, which is something we can verify now that we have a periodical build. That's the most important one. Apart from that (and it is something the soap based provider is missing) the provider should ideally: * Honor the templateOptions.inboundPorts, and

Re: [jclouds/jclouds-labs] pb-updates-v3 (#333)

2016-11-23 Thread alibazlamit
@nacx What is the next step for moving this provider to production? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/333#issuecomment-262578988

Re: [jclouds/jclouds-labs] pb-updates-v3 (#333)

2016-10-31 Thread Ignasi Barrera
Live tests are all green :) Tests run: 94, Failures: 0, Errors: 0, Skipped: 3 Pushed to master as [61e5651b](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/61e5651b). Thanks @alibazlamit! -- You are receiving this because you are subscribed to this thread. Reply to this email

Re: [jclouds/jclouds-labs] pb-updates-v3 (#333)

2016-10-31 Thread Ignasi Barrera
BTW, I've amended the commit message before merging. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/333#issuecomment-257294527

Re: [jclouds/jclouds-labs] pb-updates-v3 (#333)

2016-10-31 Thread alibazlamit
@nacx removed duplicates. and squashed. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/333#issuecomment-257267014

Re: [jclouds/jclouds-labs] pb-updates-v3 (#333)

2016-10-31 Thread alibazlamit
@alibazlamit pushed 1 commit. abb5027 Removed duplicates in live tests -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-labs] pb-updates-v3 (#333)

2016-10-30 Thread Ignasi Barrera
nacx commented on this pull request. Just a couple minors. Apart from that LGTM! Thanks @alibazlamit! > @@ -69,30 +72,31 @@ public void testCreateServer() { .cores(1) .ram(1024) .build()); - + + assertRequestCompleted(testServer);

Re: [jclouds/jclouds-labs] pb-updates-v3 (#333)

2016-10-28 Thread alibazlamit
@alibazlamit pushed 1 commit. 6af4e89 minor change to the return type -- You are receiving this because you are subscribed to this thread. View it on GitHub:

[jclouds/jclouds-labs] pb-updates-v3 (#333)

2016-10-28 Thread alibazlamit
@nacx Here is the v3 updates with the fixed two live tests that were failing, ready for review. Thanks. You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/333 -- Commit Summary -- * pb-updates-v3 -- File Changes -- M