[jclouds/jclouds-site] JCLOUDS-1414: Keystone authentication improvment (#216)

2018-05-11 Thread Alix Lourme
Following #214, some OpenStack keystone authentication improvments, following @demobox review. You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-site/pull/216 -- Commit Summary -- * JCLOUDS-1414: Keystone authentication improvment -- File Ch

Re: [jclouds/jclouds-site] JCLOUDS-1414: Keystone authentication improvment (#216)

2018-05-11 Thread jclouds-commentator
Go to http://9ee4695ccebd96b41334-2a21ba0b2756ec3f93728892323454a7.r87.cf5.rackcdn.com/ to review your changes. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/216#issuecomment

Re: [jclouds/jclouds-site] JCLOUDS-1414: Keystone authentication improvment (#216)

2018-05-12 Thread Andrew Phillips
demobox approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/216#pullrequestreview-119628028

Re: [jclouds/jclouds-site] JCLOUDS-1414: Keystone authentication improvment (#216)

2018-05-12 Thread Andrew Phillips
[Preview here](http://9ee4695ccebd96b41334-2a21ba0b2756ec3f93728892323454a7.r87.cf5.rackcdn.com/guides/openstack/). +1, looks good to me - thanks, Ignasi! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/j

Re: [jclouds/jclouds-site] JCLOUDS-1414: Keystone authentication improvment (#216)

2018-05-14 Thread Ignasi Barrera
Merged and published. Thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/216#issuecomment-388736278

Re: [jclouds/jclouds-site] JCLOUDS-1414: Keystone authentication improvment (#216)

2018-05-14 Thread Ignasi Barrera
Closed #216. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/216#event-1624206074