@melanj I am closing this PR since vcloud and vcloud-director have been removed
from both the [jclouds](https://github.com/jclouds/jclouds/pull/604) and
[jclouds-labs](https://github.com/jclouds/jclouds-labs/pull/111) repos. cc
@demobox @nacx
---
Reply to this email directly or view it on
Closed #418.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/418#event-219765488
+import org.jclouds.http.HttpRequest.Builder;
+import org.jclouds.http.HttpRequestFilter;
+import org.jclouds.http.filters.BasicAuthentication;
+import org.jclouds.location.Provider;
+import org.jclouds.rest.annotations.ApiVersion;
+
+@Singleton
+public class VCloudBasicAuthentication
+this.creds = ((Supplier)Preconditions.checkNotNull(creds, creds));
+this.apiVersion = apiVersion;
+ }
+
+ public HttpRequest filter(HttpRequest request) throws HttpException
+ {
+Credentials currentCreds =
(Credentials)Preconditions.checkNotNull(this.creds.get(),
heh nice to limp this along, though we really ought finish
https://github.com/jclouds/jclouds-labs/tree/master/vcloud-director
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/418#issuecomment-57894734
}
@Override
public HttpRequest filter(HttpRequest request) throws HttpException {
- String token = vcloudTokenProvider.get();
- return request
- .toBuilder()
- .replaceHeaders(
-
@@ -44,7 +48,20 @@
@Override
public IterableCatalog apply(final Org org) {
- return transform(org.getCatalogs().values(), new
FunctionReferenceType, Catalog() {
+
+ CollectionReferenceType filtered = Collections2.filter(
+
+this.creds = ((Supplier)Preconditions.checkNotNull(creds, creds));
+this.apiVersion = apiVersion;
+ }
+
+ public HttpRequest filter(HttpRequest request) throws HttpException
+ {
+Credentials currentCreds =
(Credentials)Preconditions.checkNotNull(this.creds.get(),
Thanks @melanj! Just a couple comments:
* [ ] Address the comments above.
* [ ] Use a 3 space indent and a 120 line length in Java classes.
* [ ] Run `mvn checkstyle:checkstyle` from the `vcloud` folder and address the
violations (you'll find them in the `target/checkstyle-result.xml` file).
* [
Thanks for the feedback @nacx. I will work on the suggestions/ improvements
that you mentioned.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/418#issuecomment-47107377
[jclouds ยป jclouds
#1268](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1268/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
[jclouds-java-7-pull-requests
#1392](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1392/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/418#issuecomment-46810761
Please review the patch
You can merge this Pull Request by running:
git pull https://github.com/melanj/jclouds master
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/418
-- Commit Summary --
* [JCLOUDS-609] Adding vCloud API 1.5 support
--
13 matches
Mail list logo
