backport to
[1.9.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/cc1217b5)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/838#issuecomment-129956125
Merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/1163b94c)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/838#issuecomment-129953297
Closed #838.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/838#event-379347047
Just a couple minors. Apart from that lgtm! Thanks @andreaturli!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/838#issuecomment-129879552
>
> @BeforeClass(groups = {"integration", "live"})
> @Override
> public void setup() {
>super.setup();
>virtualGuestApi = api.getVirtualGuestApi();
> + datacenter = Iterables.get(api.getDatacenterApi().listDatacenters(),
> 0);
> + assertNull(datacenter, "Dat
> @@ -61,13 +62,15 @@ public void testLaunchClusterWithMinDisk() throws
> RunNodesException {
>new SshjSshClientModule()))
>.build(ComputeServiceContext.class);
>
> + for (ComputeMetadata computeMetadata :
> context.getComputeService().listNodes()) {
thanks @nacx, comments addressed
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/838#issuecomment-129854249
>
> @BeforeClass(groups = {"integration", "live"})
> @Override
> public void setup() {
>super.setup();
>virtualGuestApi = api.getVirtualGuestApi();
> + datacenter = Iterables.get(api.getDatacenterApi().listDatacenters(),
> 0);
> + if (datacenter == null) Ass
> @@ -89,6 +93,13 @@ public NodeMetadata apply(VirtualGuest from) {
>
> builder.publicAddresses(ImmutableSet.of(from.getPrimaryIpAddress()));
>if (from.getPrimaryBackendIpAddress() != null)
>
> builder.privateAddresses(ImmutableSet.of(from.getPrimaryBackendIpAddress())
> @@ -52,7 +53,10 @@ public boolean apply(VirtualGuestBlockDevice input) {
> .transform(new Function Volume>() {
> @Override
> public Volume apply(VirtualGuestBlockDevice
> item) {
> -
- fix VirtualGuestBlockDeviceTemplateGroupApiLiveTest
- fix SoftLayerComputeServiceLiveTest
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/838
-- Commit Summary --
* [SoftLayer] fix some failing LiveTests
-- File Changes --
M
pr
11 matches
Mail list logo
