Closed #806.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/806#event-355939619
merged, backported. Thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/806#issuecomment-121431327
@zack-shoylev Thanks for the tip. It looks like its fixed now. I see only one
commit in PR page.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/806#issuecomment-121368999
Hm, no, that seems to have messed it up again.
What I do: In my PR branch, I rebase the last 2 (or more) commits:
git rebase -i HEAD~2
Then I force push to the github branch I used for the pull request:
git push -f
---
Reply to this email directly or view it on GitHub:
https://github.com/jclou
@zack-shoylev did i get the rebase to single commit right this time? Or else i
can create a new pull request with just the single commit.
Also, the bugs which i fixed are tracked as part of JIRA. Do i need to do
anything to update their status?
---
Reply to this email directly or view it on Git
Thanks for explaining! In this case, this should be good to merge - rebase to a
single commit.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/806#issuecomment-121258189
everything under the zone scoped package is being deprecated. If you look at
the original bug request, it has the bullet point below
Move AvailabilityZone and ZoneState from the deprecated
org.jclouds.openstack.nova.v2_0.domain.zonescoped package to the correct
org.jclouds.openstack.nova.v2_0.d
Ok. Thanks, ran it and looks good, but I have some questions:
It seems you need to deprecate, because you are using a new AvailabilityZone
class. Why not just update the old availability zone so you don't have to
deprecate it? It seems the new one is just adding stuff, so it should be
backwards
@zack-shoylev I added the the tests for deprecated code as well.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/806#issuecomment-121021892
i am creating tests named DeprecatedAvailabilityZoneApiExpectTest and
DeprecatedAvailabilityZonesApiLiveTest to test the deprecated code.
If you guys have a better naming pattern, i can use that.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/806#i
> @@ -34,11 +33,21 @@ public void testListAvailabilityZones() throws Exception {
>
>Optional availabilityZoneApi =
> api.getAvailabilityZoneApi("RegionOne");
>if (availabilityZoneApi.isPresent()) {
> - FluentIterable zones =
> availabilityZoneApi.get().list();
> +
> @@ -34,11 +33,21 @@ public void testListAvailabilityZones() throws Exception {
>
>Optional availabilityZoneApi =
> api.getAvailabilityZoneApi("RegionOne");
>if (availabilityZoneApi.isPresent()) {
> - FluentIterable zones =
> availabilityZoneApi.get().list();
> +
Closed #806.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/806#event-353012009
Adding missing "hosts" field to OpenStack Nova AvailabilityZone.
Fixes bug https://issues.apache.org/jira/browse/JCLOUDS-700
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/806
-- Commit Summary --
* Adding missing "hosts" field to Op
14 matches
Mail list logo
