Re: [jclouds] Allow Guava MediaType for Content-Type (#44)

2014-05-27 Thread Andrew Gaul
I abandoned this pull request since I no longer have write access to the maginatics organization. Continuing with #383. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/44#issuecomment-44360280

Re: [jclouds] Allow Guava MediaType for Content-Type (#44)

2014-05-27 Thread Andrew Gaul
Closed #44. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/44#event-125385919

Re: [jclouds] Allow Guava MediaType for Content-Type (#44)

2014-05-27 Thread Andrew Phillips
@andrewgaul: Close'n'reopen to trigger the builders again? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/44#issuecomment-44360065

Re: [jclouds] Allow Guava MediaType for Content-Type (#44)

2014-05-27 Thread Andrew Gaul
>public PayloadBlobBuilder contentType(String contentType) { > - payload.getContentMetadata().setContentType(contentType); > + > payload.getContentMetadata().setContentType(checkNotNull(contentType, > "contentType")); Removed ```checkNotNull```. --- Reply to this email d

Re: [jclouds] Allow Guava MediaType for Content-Type (#44)

2014-05-27 Thread Everett Toews
During release week we like to do a little house cleaning in the jclouds world. That means sweeping out the pull request queue. This PR is over 6 months old. Please update us on its status here. If we don't hear anything, we will take that as lazy consensus that the PR is no longer relevant and

Re: [jclouds] Allow Guava MediaType for Content-Type (#44)

2014-03-17 Thread Andrew Phillips
If I'm understanding this correctly, we're now no longer allowing `null` as an argument for the String version of the method. Is that as intended? If so, should we add some kind of deprecation warning to 1.7.x? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jcl

Re: [jclouds] Allow Guava MediaType for Content-Type (#44)

2014-03-17 Thread Andrew Phillips
>public PayloadBlobBuilder contentType(String contentType) { > - payload.getContentMetadata().setContentType(contentType); > + > payload.getContentMetadata().setContentType(checkNotNull(contentType, > "contentType")); What happened previously if this was set to `null`? It

Re: [jclouds] Allow Guava MediaType for Content-Type (#44)

2014-03-13 Thread CloudBees pull request builder plugin
[jclouds-java-7-pull-requests #1130](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1130/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/44#issuecomment-37580932

Re: [jclouds] Allow Guava MediaType for Content-Type (#44)

2014-03-13 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #660](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/660/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/44#issuecomment-37580579

Re: [jclouds] Allow Guava MediaType for Content-Type (#44)

2014-03-13 Thread BuildHive
[jclouds ยป jclouds #911](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/911/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/44#issuecomment-

Re: [jclouds] Allow Guava MediaType for Content-Type (#44)

2014-03-13 Thread Andrew Gaul
Worked around Clojure errors with help from @hugoduncan. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/44#issuecomment-37574363