Re: [jclouds] Always return ETag in filesystem object store get response (#850)

2016-01-28 Thread Andrew Gaul
Reverted in 86e947ddedfa1a13976f9debeadae1da6f2f0190. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/850#issuecomment-176616727

Re: [jclouds] Always return ETag in filesystem object store get response (#850)

2015-08-22 Thread Nate Rosenblum
> The case I am concerned about is when jclouds is used to expose files not > written through jclouds. In those cases getUserDefinedFileAttributeView() > would not return null but the extended attribute would not have been written. I'm fine with it if you'd like to revert this change. I _would_

Re: [jclouds] Always return ETag in filesystem object store get response (#850)

2015-08-22 Thread Ka-Hing Cheung
The case I am concerned about is when jclouds is used to expose files not written through jclouds. In those cases getUserDefinedFileAttributeView() would not return null but the extended attribute would not have been written. --- Reply to this email directly or view it on GitHub: https://github.

Re: [jclouds] Always return ETag in filesystem object store get response (#850)

2015-08-21 Thread Nate Rosenblum
> LocalBlobStore calls getBlob on the storage strategy during listContainer, > this change will make it unbearably slow for the cases when the md5 needs to > be generated at run time. That's unfortunate, though it looks like this patch simply closed a corner case on OS X, where the user extende

Re: [jclouds] Always return ETag in filesystem object store get response (#850)

2015-08-21 Thread Ka-Hing Cheung
`LocalBlobStore` calls getBlob on the storage strategy during listContainer, this change will make it unbearably slow for the cases when the md5 needs to be generated at run time. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/850#issuecomment-1335

Re: [jclouds] Always return ETag in filesystem object store get response (#850)

2015-08-20 Thread Andrew Gaul
Pushed to master as 496e27f1afa32b90d0656c3f21387cf68a30cb31. Thank you for your contribution @flandr! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/850#issuecomment-133188107

Re: [jclouds] Always return ETag in filesystem object store get response (#850)

2015-08-20 Thread Andrew Gaul
Closed #850. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/850#event-388196209

Re: [jclouds] Always return ETag in filesystem object store get response (#850)

2015-08-20 Thread Nate Rosenblum
> Can you change this to always provide an ETag for consistency with real > blobstores? Currently we return the ETag if the putBlob request included > Content-MD5 or generate it if the filesystem does not support > UserDefinedFileAttributeView (Mac OS X, NFS mounts). We can either remove the >