+1 - looks good to me. Thanks, @zack-shoylev!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/307#issuecomment-36664245
[jclouds » jclouds
#879](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/879/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/307#issuecomment
[jclouds-java-7-pull-requests
#1101](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1101/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/307#issuecomment-36578148
[jclouds-pull-requests
#631](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/631/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/307#issuecomment-36577622
Closed #307.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/307
Getting ready to merge, then work on backport.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/307#issuecomment-36572915
> jclouds-java-7-pull-requests #1099 UNSTABLE
Another unrelated [test
failure](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/org.apache.jclouds$jclouds-compute/1099/testReport/junit/org.jclouds.compute.callables/BlockUntilInitScriptStatusIsZeroThenReturnOutputTest/testloopUnti
[jclouds-java-7-pull-requests
#1099](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1099/)
UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/307#issuecomment-36552436
[jclouds-pull-requests
#629](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/629/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/307#issuecomment-36551978
Also this needs to be backported.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/307#issuecomment-36551884
> jclouds » jclouds #877 UNSTABLE
Unrelated [test
failure](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/org.apache.jclouds$jclouds-core/877/testReport/junit/org.jclouds.rest.functions/PresentWhenApiVersionLexicographicallyAtOrAfterSinceApiVersionTest/testCacheIsFasterWhenAnnotationPres
[jclouds » jclouds
#877](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/877/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclou
> @@ -541,5 +561,18 @@ public NovaTemplateOptions userData(byte[] userData) {
> public NovaTemplateOptions diskConfig(String diskConfig) {
>this.diskConfig = diskConfig;
>return this;
> - }
> + }
> +
> + /**
> +* OpenStack can be configured to write metadata to a specia
> @@ -290,6 +297,7 @@ public CreateServerOptions metadata(Map
> metadata) {
> * Custom user-data can be also be supplied at launch time.
> * It is retrievable by the instance and is often used for launch-time
> configuration
> * by instance scripts.
> +* This parameter will be
> @@ -541,5 +561,18 @@ public NovaTemplateOptions userData(byte[] userData) {
> public NovaTemplateOptions diskConfig(String diskConfig) {
>this.diskConfig = diskConfig;
>return this;
> - }
> + }
> +
> + /**
> +* OpenStack can be configured to write metadata to a specia
> @@ -297,6 +305,14 @@ public CreateServerOptions userData(byte[] userData) {
> }
>
> /**
> +* This needs to be set to "true" when trying to use user data for
> cloud-init.
Good point, I will have to look into that. Not completely sure how user-data is
used by itself.
---
Reply to
I guess you are right. It is really adding support for previously missing
functionality.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/307#issuecomment-36524896
Thanks also for the style cleanup. Why is this a bugfix, by the way? Looks like
new functionality?
Not that that matters, just out of curiosity...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/307#issuecomment-36430950
> @@ -297,6 +305,14 @@ public CreateServerOptions userData(byte[] userData) {
> }
>
> /**
> +* This needs to be set to "true" when trying to use user data for
> cloud-init.
Document the base case as well as the "exceptional" (cloud-init) case?
Something like: "Set to true to use a
> @@ -290,6 +297,7 @@ public CreateServerOptions metadata(Map
> metadata) {
> * Custom user-data can be also be supplied at launch time.
> * It is retrievable by the instance and is often used for launch-time
> configuration
> * by instance scripts.
> +* This parameter will be
> @@ -541,5 +561,18 @@ public NovaTemplateOptions userData(byte[] userData) {
> public NovaTemplateOptions diskConfig(String diskConfig) {
>this.diskConfig = diskConfig;
>return this;
> - }
> + }
> +
> + /**
> +* OpenStack can be configured to write metadata to a specia
[jclouds-java-7-pull-requests
#1098](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1098/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/307#issuecomment-36414275
[jclouds-pull-requests
#628](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/628/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/307#issuecomment-36414126
[jclouds » jclouds
#876](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/876/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/307#issuecomment
https://issues.apache.org/jira/browse/JCLOUDS-481
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/307#issuecomment-36412844
You can merge this Pull Request by running:
git pull https://github.com/rackspace/jclouds fix-nova-user-data
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/307
-- Commit Summary --
* Better documentation and a bugfix for cloud-init
-- Fil
26 matches
Mail list logo
