@demobox Yes, absolutely! Let me draft something up and get it on the wiki. I
have to say that this has already helped my daily workflow! ;)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/464#issuecomment-55418060
Bearing in mind the recent question on the dev list: would it make sense to add
a short note to the dev wiki explaining that we enable Checkstyle by default,
and that you will have to be Checkstyle-compliant for your PR to get in, but
that you can disable it locally if you really want to?
---
R
This will help a lot. Thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/464#issuecomment-55330813
Pushed to master 9384575
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/464#issuecomment-55327344
Closed #464.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/464#event-164453739
PS: I've also configured the Violations settings for the PR builder to use the
new Zero Tolerance policy ;-)
Was:
Now:
provides the necessary motivation to merge this PR today. If I don't hear
anything by 2pm today, its going into the build. :+1:
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclou
:+1: This will help reduce overhead on reviews, and shame guys like me into
getting checkstyle review as part of my local workflow in my IDE :-)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/464#issuecomment-52099949
[jclouds-pull-requests
#1060](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1060/) ABORTED
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/464#issuecomment-51510427
[jclouds » jclouds
#1464](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1464/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/464#issuecomme
[jclouds-java-6-pull-requests
#1532](https://jclouds.ci.cloudbees.com/job/jclouds-java-6-pull-requests/1532/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/464#issuecomment-51382749
I don't understand this change, why do we use Checkstyle on XML and JSON files?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/464#issuecomment-51094552
I'm all for enabling the build failure. I don't think someone looking at the
Checkstyle warnings and saying fix x, y, and z warning is a good use of review
time. Checkstyle should simply fail the build. Then we know both locally and in
the build that the code is clean w.r.t Checkstyle.
For this
@demobox Thanks for the feedback! In the meantime, I will test the change with
the dependent projects to make sure they are happy as well. :+1:
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/464#issuecomment-50966401
I'm good with all the fixes (thanks for the cleanup, @jdaggett!) but would like
to get some comments from others on enabling the build failure.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/464#issuecomment-50952616
[jclouds-java-7-pull-requests
#1524](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1524/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/464#issuecomment-50952353
[jclouds-pull-requests
#1052](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1052/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/464#issuecomment-50952206
[jclouds » jclouds
#1452](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1452/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/464#issuecomme
[jclouds-pull-requests
#1051](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1051/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/464#issuecomment-50950308
[jclouds-java-7-pull-requests
#1523](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1523/)
FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/464#issuecomment-50950270
Changing the PR builder config is a different approach - less intrusive but
also more lenient. I'm curious to see which one we prefer. For now, I think
it's worth seeing if the PR builder approach helps before making "hard" changes
such as this one.
What do you think, @jdaggett?
---
Reply to t
[jclouds » jclouds
#1451](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1451/) FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclo
This PR updates the Maven Checkstyle plugin configuration to fail the build on
*any* warnings. The configuration of the plugin has been changed to execute the
`check` goal during the `verify` phase.
DO NOT MERGE! This is a WIP and I will need to update the 198 violations before
it can be merged
26 matches
Mail list logo
