Backported to
[1.8.x](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=d3234b7299f38785b9ddd4a71ef6799d678ee3de)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/472#issuecomment-52578914
This requires downgrading maven-checkstyle-plugin to 2.11
The fix version for the
[issue](https://jira.codehaus.org/browse/MCHECKSTYLE-225) also lists 2.12.1,
which is already published. But the dates of the comments in the issue
describing the fix don't seem to line up. Seeing the diff in
@@ -669,7 +669,7 @@
/plugin
plugin
artifactIdmaven-checkstyle-plugin/artifactId
-version2.12.1/version
+version2.11/version
Could you add a comment here that we need a version that fixed MCHECKSTYLE-225?
---
Reply to this email directly or view it on
jclouds-pull-requests #1075 UNSTABLE
This is related to two [Checkstyle
violations](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1075/org.apache.jclouds.provider$softlayer/violations/)
in SoftLayer, i.e. unrelated to this commit.
---
Reply to this email directly or view it on
One minor comment about adding a clarifying comment to explain the reason for
being behind on the Checkstyle plugin version. Otherwise, +1 - looks good to me.
Thanks for figuring this out, @andrewgaul!
---
Reply to this email directly or view it on GitHub:
Hi @demobox I think it should be ok now with PR
https://github.com/jclouds/jclouds/pull/476
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/472#issuecomment-51773373
I think it should be ok now
Thanks, @andreaturli! @andrewgaul Guess it's worth rebasing this on master once
Andrea's PR is merged?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/472#issuecomment-51774380
@@ -669,7 +669,7 @@
/plugin
plugin
artifactIdmaven-checkstyle-plugin/artifactId
-version2.12.1/version
+version2.11/version
I retested with 2.12.1 and this works as-is. I must have tested this
incorrectly earlier.
---
Reply to this email directly or
Closed #472.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/472#event-151482419
@@ -669,7 +669,7 @@
/plugin
plugin
artifactIdmaven-checkstyle-plugin/artifactId
-version2.12.1/version
+version2.11/version
I retested with 2.12.1 and this works as-is.
Ah, good to know!
---
Reply to this email directly or view it on GitHub:
This commit uncovered multiple headers incorrectly attributed to jclouds, Inc.
and with various typos.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/472#issuecomment-51707177
[jclouds-java-6-pull-requests
#4](https://jclouds.ci.cloudbees.com/job/jclouds-java-6-pull-requests/4/)
FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/472#issuecomment-51707626
[jclouds-pull-requests
#1074](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1074/)
UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/472#issuecomment-51707915
[jclouds ยป jclouds
#1488](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1488/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
[jclouds-pull-requests
#1075](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1075/)
UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/472#issuecomment-51708497
This requires downgrading maven-checkstyle-plugin to 2.11 to work
around MCHECKSTYLE-225.
You can merge this Pull Request by running:
git pull https://github.com/andrewgaul/jclouds checkstyle-copyright-header
Or you can view, comment on it, or merge it online at:
16 matches
Mail list logo
