Re: [jclouds] Fix Softlayer template options (#654)

2015-01-28 Thread Ignasi Barrera
That's right. When in doubt, you can check the builds at: https://jclouds.ci.cloudbees.com/ Those run after every commit and publish the snapshots to the snapshots repo. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/654#issuecomment-71871560

Re: [jclouds] Fix Softlayer template options (#654)

2015-01-28 Thread Andrea Turli
correct! it should be already available in 2.0.0-SNAPSHOT available in maven central, I think. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/654#issuecomment-71862219

Re: [jclouds] Fix Softlayer template options (#654)

2015-01-28 Thread Andrew Donald Kennedy
@andreaturli will this become part of jclouds 1.9.0 as well as 2.0.0 then? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/654#issuecomment-71861410

Re: [jclouds] Fix Softlayer template options (#654)

2015-01-28 Thread Andrea Turli
Closed #654. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/654#event-225930035

Re: [jclouds] Fix Softlayer template options (#654)

2015-01-28 Thread Andrea Turli
Merged as https://git1-us-west.apache.org/repos/asf?p=jclouds.git;a=commit;h=9e1d1cbfa9e2d77fe8b7e8feeae0bb4222654692 @grkvlt thanks! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/654#issuecomment-71800808

Re: [jclouds] Fix Softlayer template options (#654)

2015-01-28 Thread Andrea Turli
thanks @grkvlt! lgtm +1 merging now --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/654#issuecomment-71797889

Re: [jclouds] Fix Softlayer template options (#654)

2015-01-27 Thread Andrew Donald Kennedy
@andreaturli Can you have a look at this, please? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/654#issuecomment-71707229

[jclouds] Fix Softlayer template options (#654)

2015-01-27 Thread Andrew Donald Kennedy
Changed the builder methods to return `SoftLayerTemplateOptions` to allow chaining. Always set the `diskType` when creating a VM, even if no block device configured, to allow use of `LOCAL` disk. You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds