@@ -62,7 +62,7 @@ protected void configure() {
@Provides
@Singleton
public MultimapURI, URI aliases() {
- return ImmutableMultimap.URI, URIbuilder()
+ return customAliases(ImmutableMultimap.URI, URIbuilder()
Good approach. It works for both the HP and rackspace
The last change completely refactors how the extension namespace aliases are
configured. Now aliases are configured using Guice multibindings to allow
providers to contribute their own aliases in a clean way.
This also fixes the HPCloud volume attachment configuration and adds the
Also note that the bindings configured in the providers are *added* to the
aliases map; they don't override the existing keys, but that should be aligned
with the current behavior, that already expects more than one namespace URI for
a given extension type (see
Hey jenkins, rebuild please
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/711#issuecomment-85117598
Once this is in, [this
commit](https://github.com/nacx/jclouds-labs-openstack/commit/8b252a4f3487a5533ace98da14f76c8e799810ad)
will need to be cherry-picked in jclouds-labs-openstack to align Neutron with
the changes in this PR. /cc @zack-shoylev
---
Reply to this email directly or view it on
Pushed to master as
[4db2b75a](https://git1-us-west.apache.org/repos/asf?p=jclouds.git;a=commit;h=4db2b75a).
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/711#issuecomment-85253360
Seems to work with both UK and US Rackspace providers!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/711#issuecomment-85236999
@@ -91,17 +91,16 @@ protected void configure() {
}
}
+ // Allow providers to cleanly contribute their own aliases
The
[MapBinder](http://google.github.io/guice/api-docs/latest/javadoc/index.html?com/google/inject/multibindings/MapBinder.html)
javadoc already has the detailed
Thanks for helping with the testing @zack-shoylev, @everett-toews!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/711#issuecomment-85254266
:+1:
Success on OpenStack Juno (with DevStack)
mvn clean test -Plive
-Dtest.openstack-nova.endpoint=http://$DEVSTACK_HOST:5000/v2.0/
-Dtest.openstack-nova.identity=demo:demo
-Dtest.openstack-nova.credential=devstack
-Dtest.openstack-nova.image-id=$IMAGE_ID
@@ -91,17 +91,16 @@ protected void configure() {
}
}
+ // Allow providers to cleanly contribute their own aliases
Maybe add some more info about the mechanics of it.
---
Reply to this email directly or view it on GitHub:
11 matches
Mail list logo
