Re: [jclouds] JCLOUDS-213: Fixing SoftLayer support (#247)

2014-03-04 Thread ahgittin
Closed #247. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/247

Re: [jclouds] JCLOUDS-213: Fixing SoftLayer support (#247)

2014-03-04 Thread ahgittin
actually this is rendered obsolete by #296 - closing - but please look at #296 ! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/247#issuecomment-36608369

Re: [jclouds] JCLOUDS-213: Fixing SoftLayer support (#247)

2014-03-04 Thread ahgittin
@nacx now that checkstyle is fixed can we merge this? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/247#issuecomment-36606926

Re: [jclouds] JCLOUDS-213: Fixing SoftLayer support (#247)

2014-02-17 Thread ahgittin
@demobox that was based on a `push -f` before the checkstyle failures -- they seem to be gone at https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1076/ --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/247#issuecomment-35297559

Re: [jclouds] JCLOUDS-213: Fixing SoftLayer support (#247)

2014-02-17 Thread BuildHive
[jclouds » jclouds #849](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/849/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/247#issuecomment

Re: [jclouds] JCLOUDS-213: Fixing SoftLayer support (#247)

2014-02-17 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #605](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/605/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/247#issuecomment-35296398

Re: [jclouds] JCLOUDS-213: Fixing SoftLayer support (#247)

2014-02-17 Thread Andrew Phillips
> jclouds-pull-requests #604 SUCCESS and > jclouds-java-7-pull-requests #1075 SUCCESS still show 17 [checkstyle violations](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1075/org.apache.jclouds.provider$softlayer/violations/). Are we using the same settings? --- Reply to t

Re: [jclouds] JCLOUDS-213: Fixing SoftLayer support (#247)

2014-02-17 Thread CloudBees pull request builder plugin
[jclouds-java-7-pull-requests #1076](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1076/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/247#issuecomment-35296284

Re: [jclouds] JCLOUDS-213: Fixing SoftLayer support (#247)

2014-02-17 Thread CloudBees pull request builder plugin
[jclouds-java-7-pull-requests #1075](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1075/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/247#issuecomment-35292954

Re: [jclouds] JCLOUDS-213: Fixing SoftLayer support (#247)

2014-02-17 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #604](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/604/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/247#issuecomment-35292524

Re: [jclouds] JCLOUDS-213: Fixing SoftLayer support (#247)

2014-02-17 Thread BuildHive
[jclouds » jclouds #848](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/848/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/247#issuecomment

Re: [jclouds] JCLOUDS-213: Fixing SoftLayer support (#247)

2014-02-17 Thread ahgittin
as per #247 now builds cleanly with checkstyle /cc @nacx @demobox --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/247#issuecomment-35288736

Re: [jclouds] JCLOUDS-213: Fixing SoftLayer support (#247)

2014-02-17 Thread ahgittin
@nacx @demobox now builds cleanly with checkstyle. thanks for the pointers @nacx. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/247#issuecomment-35288700

Re: [jclouds] JCLOUDS-213: Fixing SoftLayer support (#247)

2014-02-12 Thread Ignasi Barrera
@ahgittin Could you fix what @demobox commented so we can merge this? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/247#issuecomment-34922387