Re: [jclouds] JCLOUDS-317: Add missing states to Nova v2 Server (#334)

2014-04-05 Thread Andrew Phillips
> @@ -59,7 +59,15 @@ > */ > public static enum Status { > > - ACTIVE, BUILD, REBUILD, SUSPENDED, PAUSED, RESIZE, VERIFY_RESIZE, > REVERT_RESIZE, PASSWORD, REBOOT, HARD_REBOOT, DELETED, UNKNOWN, ERROR, > STOPPED, UNRECOGNIZED; > + ACTIVE, BUILD, REBUILD, SUSPENDED, PAUSED, RE

Re: [jclouds] JCLOUDS-317: Add missing states to Nova v2 Server (#334)

2014-04-03 Thread Everett Toews
Closed #334. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/334

Re: [jclouds] JCLOUDS-317: Add missing states to Nova v2 Server (#334)

2014-04-03 Thread Everett Toews
Squashed and merged to master and 1.7.x --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/334#issuecomment-39516000

Re: [jclouds] JCLOUDS-317: Add missing states to Nova v2 Server (#334)

2014-04-03 Thread BuildHive
[jclouds » jclouds #993](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/993/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/334#issuecomment

Re: [jclouds] JCLOUDS-317: Add missing states to Nova v2 Server (#334)

2014-04-03 Thread CloudBees pull request builder plugin
[jclouds-java-7-pull-requests #1202](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1202/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/334#issuecomment-39501469

Re: [jclouds] JCLOUDS-317: Add missing states to Nova v2 Server (#334)

2014-04-03 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #732](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/732/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/334#issuecomment-39501372

Re: [jclouds] JCLOUDS-317: Add missing states to Nova v2 Server (#334)

2014-04-03 Thread jmourelos
I think I have addressed the issues pointed out during review. I must say that the lines in the serialization test are still quite long, the only solution I see is to change the real UUIDs to fake UUIDs (like 1234) as it is done in other tests. However I thought that the fact of using real paylo

Re: [jclouds] JCLOUDS-317: Add missing states to Nova v2 Server (#334)

2014-04-01 Thread Everett Toews
SGTM. No translation logic is necessary. AFAICT, the actual string "STOPPED" has never been returned by OpenStack. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/334#issuecomment-39207787

Re: [jclouds] JCLOUDS-317: Add missing states to Nova v2 Server (#334)

2014-04-01 Thread Andrew Phillips
> Can you please put the STOPPED state back? +1. Good catch, @everett-toews! What would your thoughts be on deprecating it in 1.7.x and removing it on master? Do we need any kind of translation logic to handle responses from older provider versions? --- Reply to this email directly or view it o

Re: [jclouds] JCLOUDS-317: Add missing states to Nova v2 Server (#334)

2014-04-01 Thread Andrew Phillips
> + .links( > + Link.create( > + Relation.SELF, > + > URI.create("http://openstack:8774/v2/4e1900cf21924a098709c23480e157c0/servers/cad76945-8851-489a-99e1-f1049e02c769";)),

Re: [jclouds] JCLOUDS-317: Add missing states to Nova v2 Server (#334)

2014-04-01 Thread Andrew Phillips
> @@ -82,6 +83,42 @@ public void testListServersWhenReponseIs404IsEmpty() > throws Exception { > > assertTrue(apiWhenNoServersExist.getServerApiForZone("az-1.region-a.geo-1").list().concat().isEmpty()); > } > > +public void testListInDetailServersWhenResponseIs2xx() throws Except

Re: [jclouds] JCLOUDS-317: Add missing states to Nova v2 Server (#334)

2014-03-31 Thread Everett Toews
Can you please put the STOPPED state back? I realize the OpenStack doesn't return this but that state has been in jclouds for a long time and some code is bound to depend on it. @Deprecated STOPPED and add a comment telling users to change it to SHUTOFF. --- Reply to this email directly or vie

Re: [jclouds] JCLOUDS-317: Add missing states to Nova v2 Server (#334)

2014-03-27 Thread CloudBees pull request builder plugin
[jclouds-java-7-pull-requests #1188](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1188/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/334#issuecomment-38875451

Re: [jclouds] JCLOUDS-317: Add missing states to Nova v2 Server (#334)

2014-03-27 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #718](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/718/) UNSTABLE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/334#issuecomment-38874883

Re: [jclouds] JCLOUDS-317: Add missing states to Nova v2 Server (#334)

2014-03-27 Thread BuildHive
[jclouds » jclouds #975](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/975/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/334#issuecomment

Re: [jclouds] JCLOUDS-317: Add missing states to Nova v2 Server (#334)

2014-03-27 Thread jmourelos
I have seen in the JIRA issue that the 1.6.x version is marked as affected, so I guess that either the pull request should be also backported to the 1.6.x version or the "Affects version/s" field in the JIRA ticket should be changed accordingly (but I do not have permissions to do so). --- Repl

[jclouds] JCLOUDS-317: Add missing states to Nova v2 Server (#334)

2014-03-27 Thread jmourelos
- Remove state: STOPPED - Add states: MIGRATING, SHUTOFF, RESCUE, SOFT_DELETED, SHELVED, SHELVED_OFFLOADED - Related blocker issue: https://issues.apache.org/jira/browse/JCLOUDS-317 - It would very nice if, in case of being merged, the pull request could be backported to the 1.7