It's release time in jclouds and that means we like to do a little house
cleaning by sweeping out the pull request queue. This PR hasn't been touched in
over 6 months. Please give us a status update.
If we don't hear anything by the end of the week, we'll close this pull request.
---
Reply to t
Thanks Andrew for the clarification. That is a relief to know that the main
repo is not touched :)
Rgds
Jai
On Tue, Mar 18, 2014 at 9:54 AM, Andrew Phillips
wrote:
> The test failures was a bummer. I thought a commit to Github will only
> update my fork branch and I can send it for a review.
>
> +
> +request = (GeneratedHttpRequest)
> request.getFilters().get(0).filter(request);
> +
> +assertRequestLineEquals(request, "POST
> https://ec2.us-east-1.amazonaws.com/ HTTP/1.1");
> +assertNonPayloadHeadersEqual(request, "Host:
> ec2.us-east-1.amazonaws.com\n");
> +
> + * Options to specify metadata such as architecture or
> secondary volumes to be
> + * associated with this image.
> + * @return imageId
> + *
> + * @see #describeImages
> + * @see #deregisterImage
> + * @see + *
> "http://docs.amazonwe
> @@ -130,6 +135,22 @@ public RegisterImageBackedByEbsOptions
> addNewBlockDevice(String deviceName,
>return this;
> }
>
> +/**
> + *
> + * sets the ROOT device name to the specified name.
> + *
> + * @param name
> + * The device name (e.g., /dev/sdh
> @@ -130,6 +135,22 @@ public RegisterImageBackedByEbsOptions
> addNewBlockDevice(String deviceName,
>return this;
> }
>
> +/**
> + *
> + * sets the ROOT device name to the specified name.
> + *
> + * @param name
> + * The device name (e.g., /dev/sdh
> @@ -130,6 +135,22 @@ public RegisterImageBackedByEbsOptions
> addNewBlockDevice(String deviceName,
>return this;
> }
>
> +/**
> + *
> + * sets the ROOT device name to the specified name.
"Sets" (capital 'S"), and please remove the blank line above. I know "adds"
above
> @@ -44,7 +44,12 @@
>
> private int deviceIndex = 1;
>
> - /**
> +public RegisterImageBackedByEbsOptions() {
> +formParameters.put("BlockDeviceMapping.0.DeviceName", "/dev/sda1");
> +formParameters.put("RootDeviceName","/dev/sda1");
And a minor comment: missing space
> The test failures was a bummer. I thought a commit to Github will only
> update my fork branch and I can send it for a review.
You don't have to worry about the test failures. The Jenkins builds are
automatically adding your diff to a copy of the code and running tests -
nothing is changed in
Hi Ignasi,
Thanks for there review comments. I will work on incorporating them.
The test failures was a bummer. I thought a commit to Github will only
update my fork branch and I can send it for a review.
Is there a way to just hold it locally in github account and get it
reviewed before it ge
Thanks @jaiganeshm! It seems an spurious test failure.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/318#issuecomment-37794070
> @@ -44,7 +44,12 @@
>
> private int deviceIndex = 1;
>
> - /**
> +public RegisterImageBackedByEbsOptions() {
> +formParameters.put("BlockDeviceMapping.0.DeviceName", "/dev/sda1");
> +formParameters.put("RootDeviceName","/dev/sda1");
Can we remove this from here and m
> @@ -241,6 +234,7 @@ String registerImageFromManifestInRegion(
> *
> "http://docs.amazonwebservices.com/AWSEC2/latest/APIReference/ApiReference-query-RegisterImage.html";
> * />
> */
> + @Deprecated
Instead of deprecating this method, just remove the `options` paramete
> @@ -44,15 +35,17 @@
> import org.jclouds.ec2.xml.PermissionHandler;
> import org.jclouds.javax.annotation.Nullable;
> import org.jclouds.location.functions.RegionToEndpointOrProviderIfNull;
> -import org.jclouds.rest.annotations.BinderParam;
> -import org.jclouds.rest.annotations.EndpointParam
[jclouds-java-7-pull-requests
#1135](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1135/)
UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/318#issuecomment-37781144
[jclouds-pull-requests
#665](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/665/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/318#issuecomment-37780973
[jclouds » jclouds
#919](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/919/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/318#issuecomment
[jclouds-java-7-pull-requests
#1134](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1134/)
UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/318#issuecomment-37779587
[jclouds-pull-requests
#664](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/664/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/318#issuecomment-37779436
[jclouds » jclouds
#918](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/918/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclou
[jclouds-java-7-pull-requests
#1133](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1133/)
UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/318#issuecomment-37776263
[jclouds-pull-requests
#663](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/663/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/318#issuecomment-37776120
[jclouds » jclouds
#917](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/917/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclou
New API to allow users to pass root device name in the registerImage from
snapshot api.
Deprecated older api which fixed the root device name and accepted multiple
options objects as parameters.
You can merge this Pull Request by running:
git pull https://github.com/jaiganeshm/jclouds 1.7.x
O
24 matches
Mail list logo
