Re: [jclouds] JCLOUDS-514: Support attaching volumes at boot in Nova (#527)

2014-09-19 Thread Andrew Phillips
> Its already fixed and will be in the new PR. ;) Nice...thanks! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/527#issuecomment-56255875

Re: [jclouds] JCLOUDS-514: Support attaching volumes at boot in Nova (#527)

2014-09-19 Thread Jeremy Daggett
@demobox I am in the process of rewriting most of this to support Nova Boot from Volume. I noticed that `deviceName` was being returned here as well! Whoopsie. Its already fixed and will be in the new PR. ;) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jcloud

Re: [jclouds] JCLOUDS-514: Support attaching volumes at boot in Nova (#527)

2014-09-19 Thread Jeremy Daggett
> + * A representation of a block device that should be attached to the Nova > instance to be launched > + * > + */ > +public class BlockDeviceMapping { > + > + @Named("delete_on_termination") > + String deleteOnTermination = "0"; > + @Named("device_name") > + String deviceName

Re: [jclouds] JCLOUDS-514: Support attaching volumes at boot in Nova (#527)

2014-09-19 Thread Andrew Phillips
> + * A representation of a block device that should be attached to the Nova > instance to be launched > + * > + */ > +public class BlockDeviceMapping { > + > + @Named("delete_on_termination") > + String deleteOnTermination = "0"; > + @Named("device_name") > + String deviceName

Re: [jclouds] JCLOUDS-514: Support attaching volumes at boot in Nova (#527)

2014-09-19 Thread Andrew Phillips
> + return volumeSize; > + } > + > + /** > +* @return the device name to which the volume is attached > +*/ > + @Nullable > + public String getDeviceName() { > + return deviceName; > + } > + > + /** > +* @return whether the volume should be deleted on terminating t

Re: [jclouds] JCLOUDS-514: Support attaching volumes at boot in Nova (#527)

2014-09-19 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #1183](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1183/) ABORTED --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/527#issuecomment-56247877

Re: [jclouds] JCLOUDS-514: Support attaching volumes at boot in Nova (#527)

2014-09-18 Thread CloudBees pull request builder plugin
[jclouds-pull-requests-java-6 #94](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/94/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/527#issuecomment-56116994

[jclouds] JCLOUDS-514: Support attaching volumes at boot in Nova (#527)

2014-09-18 Thread Jeremy Daggett
This is a replacement PR for the work done in #326 that is rebased/squashed so that it can be pushed to master. The new Nova Boot from Volume functionality that I am currently working on is dependent on this PR. Once the builder is successful, I plan on merging immediately. You can merge this Pu