Thx!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/629#issuecomment-72017329
Thanks @aledsage
Merged at
https://git1-us-west.apache.org/repos/asf?p=jclouds.git;a=commit;h=ee42fb1a687d3f8de0db9ff870cb7e9ad00d53aa
and
https://git1-us-west.apache.org/repos/asf?p=jclouds.git;a=commit;h=7866612a2eca6e3ee32bc7928e692ec325ac7d30
---
Reply to this email directly or view it on G
Closed #629.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/629#event-226766595
I've squashed that down to two commits. I've left it as two because the changes
in the retry-predicate are logically separate from the
cleanupIncidentalResources changes. It could have been its own pull request,
but that felt unnecessary given it is being reviewed in the context of this PR.
@na
Changes lgtm. Thanks @aledsage! Mind squashing and rebasing so I can cleanly
merge it?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/629#issuecomment-71911666
@nacx @andreaturli I've added support for reconfiguring the retry timeout for
cleaning up incidental resources. Could you take another look please?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/629#issuecomment-71786070
> + assertPosted(DEFAULT_REGION,
> "Action=DescribePlacementGroups&GroupName.1=jclouds%23sg-3c6ef654%23us-east-1");
> + assertPosted(DEFAULT_REGION,
> "Action=DeletePlacementGroup&GroupName=jclouds%23sg-3c6ef654%23us-east-1");
> + assertPosted(DEFAULT_REGION,
> "Action=DescribePla
> + assertPosted(DEFAULT_REGION,
> "Action=DescribePlacementGroups&GroupName.1=jclouds%23sg-3c6ef654%23us-east-1");
> + assertPosted(DEFAULT_REGION,
> "Action=DeletePlacementGroup&GroupName=jclouds%23sg-3c6ef654%23us-east-1");
> + assertPosted(DEFAULT_REGION,
> "Action=DescribePla
> + assertPosted(DEFAULT_REGION,
> "Action=DescribePlacementGroups&GroupName.1=jclouds%23sg-3c6ef654%23us-east-1");
> + assertPosted(DEFAULT_REGION,
> "Action=DeletePlacementGroup&GroupName=jclouds%23sg-3c6ef654%23us-east-1");
> + assertPosted(DEFAULT_REGION,
> "Action=DescribePla
@aledsage code looks good to me, but the builder is not happy because of some
[checkstyle
violations](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1475/org.apache.jclouds.provider$aws-ec2/violations/)
+1 to PR against master as well, once you address the violations
---
Reply to t
Also see comments in https://issues.apache.org/jira/browse/JCLOUDS-529
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/629#issuecomment-68305954
- Some users get a `DependencyVioloation`, rather than `InvalidGroup.InUse`,
when attempting to delete the security group. This caused
`cleanupIncidentalResources` to propagate an exception.
- Fixes it by converting this to an `IllegalStateException` (in same way as is
done for `InUse`)
- Adds t
This fix targets 1.8.x branch; once that is merged successfully, we can PR this
against master as well.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/629#issuecomment-68303007
13 matches
Mail list logo
