Thanks for the pull request but it's release week in jclouds and that means
it's time to clean up the PR queue. This PR will be over 6 months old as of
April 1. If you intend to continue work on it, please make a comment by April
2. Otherwise it will be closed on April 3.
---
Reply to this
+1 after comments addressed.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/462#issuecomment-51085775
This PR provides the necessary changes for
[JCLOUDS-642](https://issues.apache.org/jira/browse/JCLOUDS-642). `InternalURL`
should fallback to use `publicUrl` if the `internalUrl` is not present for the
endpoint.
This is a WIP pending testing and could use feedback on the changes in the
Note the JIRA and PR ids for this work. That isn't confusing at all! :)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/462#issuecomment-50917589
[jclouds-pull-requests
#1049](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1049/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/462#issuecomment-50924250
[jclouds-java-7-pull-requests
#1521](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1521/)
UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/462#issuecomment-50925038
*/
@Singleton
public class InternalURL implements EndpointToSupplierURI {
@Override
public SupplierURI apply(Endpoint input) {
- return Suppliers.ofInstance(input.getInternalURL());
+ return Suppliers.ofInstance(input.getInternalURL() != null ?
input.getInternalURL()
+ .build()).get(),
+
URI.create(https://ericsson.com/v2/1900e98b-7272-4cbd-8e95-0b8c2a9266c0;));
+ }
+
+ /**
+* If the {@code internalURL} is absent, then {@link InternalURL} will
fallback to
+* use the {@code publicURL}
+*/
+ public void
+ assertEquals(
+fn.apply(Endpoint.builder().region(regionOne).versionId(2.0)
+
.publicURL(URI.create(https://ericsson.com/v2/1900e98b-7272-4cbd-8e95-0b8c2a9266c0;))
+ .build()).get(),
+
