Re: [jclouds] JCLOUDS-781 cluster regions is a subset of regions. (#613)

2014-11-20 Thread Adrian Cole
This is the only special-case I'm aware of. Definitely, jclouds.regions should trump any subordinate filters. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/613#issuecomment-63879199

Re: [jclouds] JCLOUDS-781 cluster regions is a subset of regions. (#613)

2014-11-20 Thread Andrew Phillips
Thanks for the proactive merge, @adriancole. Code itself looks fine, just wondering about the intended semantics: from what I understand, PROPERTY_EC2_CC_REGIONS is a property set by default but also overridable. Should you as a user be responsible for ensuring that if you override one, you als

Re: [jclouds] JCLOUDS-781 cluster regions is a subset of regions. (#613)

2014-11-20 Thread Adrian Cole
Closed #613. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/613#event-196235027

Re: [jclouds] JCLOUDS-781 cluster regions is a subset of regions. (#613)

2014-11-20 Thread Adrian Cole
I'm going to merge this and address feedback afterwards. We really need people as interested in AWS in jclouds, like we do in projects like openstack and google. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/613#issuecomment-63829194

Re: [jclouds] JCLOUDS-781 cluster regions is a subset of regions. (#613)

2014-11-19 Thread BuildHive
[jclouds » jclouds #1942](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1942/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/613#issuecomme

Re: [jclouds] JCLOUDS-781 cluster regions is a subset of regions. (#613)

2014-11-19 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #1405](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1405/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/613#issuecomment-63749267

Re: [jclouds] JCLOUDS-781 cluster regions is a subset of regions. (#613)

2014-11-19 Thread CloudBees pull request builder plugin
[jclouds-pull-requests-java-7 #317](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-7/317/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/613#issuecomment-63748907

Re: [jclouds] JCLOUDS-781 cluster regions is a subset of regions. (#613)

2014-11-19 Thread BuildHive
[jclouds » jclouds #1938](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1938/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/613#issuecomme

Re: [jclouds] JCLOUDS-781 cluster regions is a subset of regions. (#613)

2014-11-19 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #1401](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1401/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/613#issuecomment-63732084

Re: [jclouds] JCLOUDS-781 cluster regions is a subset of regions. (#613)

2014-11-19 Thread CloudBees pull request builder plugin
[jclouds-pull-requests-java-7 #313](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-7/313/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/613#issuecomment-63730673

Re: [jclouds] JCLOUDS-781 cluster regions is a subset of regions. (#613)

2014-11-19 Thread Adrian Cole
@demobox mind a quick look? my other pull request ran into this while working on mock tests :) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/613#issuecomment-63729310

[jclouds] JCLOUDS-781 cluster regions is a subset of regions. (#613)

2014-11-19 Thread Adrian Cole
mild cleanup, but major change is to make sure the cluster region list is a subset of regions. Manually tested by invoking AWSEC2TemplateBuilderLiveTest with `-Djclouds.regions=us-east-1`. Verified in jclouds-wire.log that no calls were made to other regions. Mock test will happen in a future c