Re: [jclouds] Modernize the VolumeAttachmentApiLiveTest (#709)

2015-03-19 Thread Zack Shoylev
Well one problem is that the current tests were broken from what I could tell. Which is why the idea was to replace them with up-to-date tests which follow what users would do (which is why @everett-toews also added the deprecation PR). I don't think this tests a cinder feature; it just tests a

Re: [jclouds] Modernize the VolumeAttachmentApiLiveTest (#709)

2015-03-19 Thread Zack Shoylev
Superceded by https://github.com/jclouds/jclouds/pull/710 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/709#issuecomment-83887035

Re: [jclouds] Modernize the VolumeAttachmentApiLiveTest (#709)

2015-03-19 Thread Ignasi Barrera
Let's see if I understand this. The volume test has started failing now, because modern OpenStack distributions come without the volume API in Nova, and the Available Volume API is through Cinder? In that case, from what I see int he changed test we are no longer exercising the deprecated Nova

Re: [jclouds] Modernize the VolumeAttachmentApiLiveTest (#709)

2015-03-19 Thread Everett Toews
Hopefully this is in reasonably good shape now. I'll be on vacation until Monday and won't have my laptop with me. If changes need to be made, go ahead and push on top of my commits or just cherry pick or whatever. I just don't want to hold the release up. --- Reply to this email directly or vi

[jclouds] Modernize the VolumeAttachmentApiLiveTest (#709)

2015-03-19 Thread Everett Toews
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/709 -- Commit Summary -- * Modernize the VolumeAttachmentApiLiveTest -- File Changes -- M apis/openstack-nova/pom.xml (6) M apis/openstack-nova/src/test/java/org/jclouds/openst