Merged to master and 1.7.x
@cdancy Thanks for the contribution! This is your first commit right?
We'd love to give you a shout out on Twitter if you're okay with that. What's
your Twitter username?
---
Reply to this email directly or view it on GitHub:
This is my first commit but not on twitter. I am however on Facebook here:
https://www.facebook.com/christoforever
and googaplus here:
https://plus.google.com/+ChristopherDancy/posts
Looking forward to contributing more code and thanks for the help.
---
Reply to this email directly or view
Congrats, @cdancy! Thanks for contributing!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/405#issuecomment-46261756
@@ -267,7 +267,22 @@ public boolean apply(NodeMetadata nodeMetadata) {
@Override
public String toString() {
- return TERMINATED;
+ return Status.TERMINATED.toString();
+ }
+ };
+
+ /**
+* Match nodes with State == SUSPENDED
+*/
+
@@ -141,6 +141,19 @@ public void testNodeRunningReturnsTrueWhenRunning() {
Assert.assertTrue(nodeRunning.apply(reference));
Assert.assertEquals(reference.get(), node);
}
+
+ @Test
+ public void testNodeSuspendedReturnsTrueWhenSuspended() {
+
@@ -141,6 +141,19 @@ public void testNodeRunningReturnsTrueWhenRunning() {
Assert.assertTrue(nodeRunning.apply(reference));
Assert.assertEquals(reference.get(), node);
}
+
+ @Test
+ public void testNodeSuspendedReturnsTrueWhenSuspended() {
+
@@ -141,6 +141,19 @@ public void testNodeRunningReturnsTrueWhenRunning() {
Assert.assertTrue(nodeRunning.apply(reference));
Assert.assertEquals(reference.get(), node);
}
+
+ @Test
+ public void testNodeSuspendedReturnsTrueWhenSuspended() {
+
Thanks for the explanations and updates, @cdancy! Pending a squash'n'rebase, +1
- looks good to go for me.
Cleanups like remove the (unnecessary, if you ask me)
`Assert.assertEquals(reference.get(), node);` assertions we can address in
another PR, if desired.
---
Reply to this email directly
[jclouds-pull-requests
#885](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/885/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/405#issuecomment-46016797
[jclouds-java-7-pull-requests
#1356](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1356/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/405#issuecomment-46016952
[jclouds » jclouds
#1221](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1221/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
[jclouds-java-7-pull-requests
#1357](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1357/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/405#issuecomment-46031405
[jclouds-pull-requests
#886](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/886/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/405#issuecomment-46032201
[jclouds » jclouds
#1222](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1222/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
Rebase/squash is done. Should be good to go. Let me know if there is anything
you guys need and/or how it looks. As I mentioned elsewhere: this is my first
time working with git so I may have fudged something up.
---
Reply to this email directly or view it on GitHub:
[jclouds-pull-requests
#888](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/888/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/405#issuecomment-46052281
[jclouds-java-7-pull-requests
#1359](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1359/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/405#issuecomment-46053642
[jclouds » jclouds
#1223](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1223/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
[jclouds-java-7-pull-requests
#1360](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1360/)
UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/405#issuecomment-46054837
[jclouds-java-7-pull-requests
#1358](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1358/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/405#issuecomment-46055512
[jclouds-pull-requests
#889](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/889/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/405#issuecomment-46056459
[jclouds » jclouds
#1224](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1224/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
[jclouds » jclouds
#1225](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1225/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
Added second commit to remove hard-coded strings inside
NodePredicates.name.toString methods which is just asking for a typo to pop.
Replaced hard-coded strings by calling their respective enum.toString() methods.
---
Reply to this email directly or view it on GitHub:
[jclouds-pull-requests
#881](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/881/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/405#issuecomment-45914352
[jclouds-java-7-pull-requests
#1352](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1352/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/405#issuecomment-45915689
[jclouds-java-7-pull-requests
#1353](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1353/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/405#issuecomment-45916178
[jclouds-pull-requests
#882](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/882/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/405#issuecomment-45917597
[jclouds » jclouds
#1217](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1217/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
Can you please a test or tests for this new predicate to
AtomicNodePredicatesTest?
You'll be able to use the tests at the bottom of that class as a template for
your test.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/405#issuecomment-45931104
Should be good to go. Nothing special just copied one of the previous testers
that fails when node is not running.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/405#issuecomment-45936032
[jclouds-pull-requests
#883](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/883/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/405#issuecomment-45938634
[jclouds-java-7-pull-requests
#1354](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1354/)
UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/405#issuecomment-45938773
[jclouds » jclouds
#1218](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1218/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
This was due to a misunderstanding, and lack of testing locally, for a code
block I assumed was fairly straight forward. Test passes locally and NOW should
be good to go ;)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/405#issuecomment-45944766
[jclouds-pull-requests
#884](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/884/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/405#issuecomment-45948778
[jclouds-java-7-pull-requests
#1355](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1355/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/405#issuecomment-45948992
[jclouds » jclouds
#1219](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1219/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
+1
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/405#issuecomment-45952583
@@ -141,6 +141,19 @@ public void testNodeRunningReturnsTrueWhenRunning() {
Assert.assertTrue(nodeRunning.apply(reference));
Assert.assertEquals(reference.get(), node);
}
+
+ @Test
+ public void testNodeSuspendedReturnsTrueWhenSuspended() {
+
@@ -141,6 +141,19 @@ public void testNodeRunningReturnsTrueWhenRunning() {
Assert.assertTrue(nodeRunning.apply(reference));
Assert.assertEquals(reference.get(), node);
}
+
+ @Test
+ public void testNodeSuspendedReturnsTrueWhenSuspended() {
+
@@ -141,6 +141,19 @@ public void testNodeRunningReturnsTrueWhenRunning() {
Assert.assertTrue(nodeRunning.apply(reference));
Assert.assertEquals(reference.get(), node);
}
+
+ @Test
+ public void testNodeSuspendedReturnsTrueWhenSuspended() {
+
42 matches
Mail list logo
