If I understand correctly, the change basically was "delegate decision to retry
to parent class on 504"? If I'm getting that right, +1 - looks good to me!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/317#issuecomment-38011814
> @@ -112,4 +113,21 @@ public Integer answer() throws Throwable {
>
> }
>
> + @Test
> + public void test504DoesRetry() {
> + AWSUtils utils = createMock(AWSUtils.class);
> + HttpCommand command = createMock(HttpCommand.class);
> + expect(command.getFailureCount()).andRetu
Closed #317.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/317
Pushed to master and 1.7.x. Thanks @tdmanv for the feedback!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/317#issuecomment-37685162
[jclouds-java-7-pull-requests
#1131](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1131/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/317#issuecomment-37682720
[jclouds-pull-requests
#661](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/661/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/317#issuecomment-37682294
[jclouds-java-7-pull-requests
#1129](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1129/)
UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/317#issuecomment-37574698
[jclouds-pull-requests
#659](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/659/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/317#issuecomment-37573917
[jclouds ยป jclouds
#910](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/910/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/317#issuecomment
Looks good to me.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/317#issuecomment-37567286
RiakCS using the S3 interface occasionally surfaces these status
codes.
You can merge this Pull Request by running:
git pull https://github.com/maginatics/jclouds s3-504-retry
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/317
-- Commit Summar
11 matches
Mail list logo
