Pushed to master as
[b54c788e](https://git1-us-west.apache.org/repos/asf?p=jclouds.git;a=commit;h=b54c788e).
I've fixed a few more test files in the `compute` project that failed the
build locally and amended the commit. I don't know why the pull request builder
has not detected that, though.
T
Ok, now it is squashed
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/701#issuecomment-78261044
>Yes, yes, the option are on both sides
Oh, I didn't refresh the page and didn't see the last commit :) Cool! If you
don't mind squashing the commits into a single one I'll merge the PR.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/701#issuecomme
Yes, yes, the option are on both sides
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/701#issuecomment-78245094
Perhaps the `-s` parameter should also be used in the "grep" part? To make sure
we look for the "smaller" hostname?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/701#issuecomment-78242257
Added "-s" option.
Now the /etc/hosts line is "ipAddress hostname -f hostname -s"
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/701#issuecomment-78239596
Thanks! WDYT about my comment of explicitly using the `-s` parameter too? In
some operating systems the `-f` might be the default behavior.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/701#issuecomment-78237431
Fixed all tests
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/701#issuecomment-78236684
Thanks @hviejo! Just one comment. Also, could you have a look at the test
failures and fix them?
https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1618/
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/701#issuecomment-78155041
> @@ -52,7 +52,7 @@ function ensure_hostname_in_hosts() {
> local ipaddr=`hostname -i`
>}
># NOTE: we blindly trust existing hostname settings in /etc/hosts
> - egrep -q `hostname` /etc/hosts || echo "$ipaddr `hostname`" >> /etc/hosts
> + egrep -q `hostname` /etc/hosts || echo "$ipad
Add the fqdn to /etc/hosts file becouse if you only add the hostname then it is
posible to lose the fqdn
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/701
-- Commit Summary --
* Update setupPublicCurl.sh
-- File Changes --
M sc
11 matches
Mail list logo
