@demobox @everett-toews : It's been a while, but finally got the tests up for
this PR, would much appreciate another review.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/326#issuecomment-42706969
@@ -102,6 +103,27 @@ public String toString() {
}
+ public static class BlockDevice{
Are you confident that BlockDevice will only ever be used within the context of
CreateServerOptions?
Also there should be a space before the {
---
Reply to this email directly or view it on
@@ -102,6 +103,27 @@ public String toString() {
}
+ public static class BlockDevice{
Going to work through getting this running through the ComputeServiceApi this
week, should have a good answer for you then. Right now, I'm not sure.
---
Reply to this email directly or view it on
@@ -102,6 +103,27 @@ public String toString() {
}
+ public static class BlockDevice{
+ @Named(volume_size)
+ String volumeSize = ;
+ @Named(volume_id)
+ String volumeId;
+ @Named(delete_on_termination)
+ int deleteOnTermination = 0;
+
@@ -102,6 +103,27 @@ public String toString() {
}
+ public static class BlockDevice{
+ @Named(volume_size)
+ String volumeSize = ;
+ @Named(volume_id)
+ String volumeId;
+ @Named(delete_on_termination)
+ int deleteOnTermination = 0;
+
+ String volumeSize = ;
+ @Named(volume_id)
+ String volumeId;
+ @Named(delete_on_termination)
+ int deleteOnTermination = 0;
+ @Named(device_name)
+ String deviceName;
+
+ public BlockDevice(String volumeId, String deviceName){
+
@@ -113,6 +135,7 @@ public String toString() {
private SetNetwork novaNetworks = ImmutableSet.of();
private String availabilityZone;
private boolean configDrive;
+ private ListBlockDevice blockDeviceMapping = Lists.newArrayList();
`ImmutableList.of()`?
---
Reply to this email
@@ -463,6 +494,21 @@ public CreateServerOptions networks(String... networks) {
return networks(ImmutableSet.copyOf(networks));
}
+ /**
+* Block volumes that should be attached to the instance at boot time
+*/
+ public ListBlockDevice getBlockDeviceMapping() {
+
@@ -463,6 +494,21 @@ public CreateServerOptions networks(String... networks) {
return networks(ImmutableSet.copyOf(networks));
}
+ /**
+* Block volumes that should be attached to the instance at boot time
+*/
+ public ListBlockDevice getBlockDeviceMapping() {
+
@@ -102,6 +103,27 @@ public String toString() {
}
+ public static class BlockDevice{
My suggestion would be to get it running properly in the NovaApi with expect
tests and live tests first. That stuff really needs to be done before you can
add proper support in the ComputeService
We'll also need more Javadoc for all of the parameters that can be used to
create a BlockDevice.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/326#issuecomment-38742092
@@ -102,6 +103,27 @@ public String toString() {
}
+ public static class BlockDevice{
Considering there's already a feature in Nova that boots from block devices
using the term block-device, I think it's more appropriate to call this object
BlockDeviceMapping.
---
Reply to this
@@ -102,6 +103,27 @@ public String toString() {
}
+ public static class BlockDevice{
Will go that route, and I'm fine with that name change (I actually started out
with that and then noticed that Nova called the entire list of block device
mappings a block device mapping itself.)
[jclouds-pull-requests
#693](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/693/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/326#issuecomment-38629321
Thanks for taking care of this @jasdeep-hundal!
To add it to the compute service api, what I'd do is to extend the
[TemplateOptions](https://github.com/jclouds/jclouds/blob/master/compute/src/main/java/org/jclouds/compute/options/TemplateOptions.java)
class by adding a method that accepts a
[jclouds ยป jclouds
#949](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/949/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
16 matches
Mail list logo
