Re: [jclouds] Work around mockwebserver hangs in S3 tests (#502)

2014-10-08 Thread Adrian Cole
Yep --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/502#issuecomment-58364504

Re: [jclouds] Work around mockwebserver hangs in S3 tests (#502)

2014-10-03 Thread Andrew Phillips
I haven't seen the problem occur recently Looks like I was a bit too optimistic, and that is **not** fixed by the change to longs: https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1206/console hanging at: ``` Test suite progress: tests succeeded: 69, failed: 0, skipped: 0. Starting

Re: [jclouds] Work around mockwebserver hangs in S3 tests (#502)

2014-10-03 Thread Andrew Phillips
maybe wrong place to discuss, but at square, we used an annotation @Flakey which would simply replay the test on failure. The thing here is that this test doesn't _fail_, it causes the build to _hang_. But for some of our other flaky tests...sure! --- Reply to this email directly or view

Re: [jclouds] Work around mockwebserver hangs in S3 tests (#502)

2014-10-02 Thread Andrew Phillips
@@ -280,7 +280,6 @@ protected void writeNothing(HttpURLConnection connection) { // HttpUrlConnection strips Content-Length: 0 without setDoOutput(true) String method = connection.getRequestMethod(); if (POST.equals(method) || PUT.equals(method)) { -

Re: [jclouds] Work around mockwebserver hangs in S3 tests (#502)

2014-10-01 Thread Adrian Cole
another way out is to change S3ClientMockTest to use okhttp's http driver. I would highly doubt that fails. Anyway this might be simple enough to reproduce, as MWS has a similar test already.

Re: [jclouds] Work around mockwebserver hangs in S3 tests (#502)

2014-10-01 Thread Andrew Phillips
@@ -280,7 +280,6 @@ protected void writeNothing(HttpURLConnection connection) { // HttpUrlConnection strips Content-Length: 0 without setDoOutput(true) String method = connection.getRequestMethod(); if (POST.equals(method) || PUT.equals(method)) { -

Re: [jclouds] Work around mockwebserver hangs in S3 tests (#502)

2014-10-01 Thread Ignasi Barrera
@@ -280,7 +280,6 @@ protected void writeNothing(HttpURLConnection connection) { // HttpUrlConnection strips Content-Length: 0 without setDoOutput(true) String method = connection.getRequestMethod(); if (POST.equals(method) || PUT.equals(method)) { -

Re: [jclouds] Work around mockwebserver hangs in S3 tests (#502)

2014-10-01 Thread Andrew Phillips
@@ -280,7 +280,6 @@ protected void writeNothing(HttpURLConnection connection) { // HttpUrlConnection strips Content-Length: 0 without setDoOutput(true) String method = connection.getRequestMethod(); if (POST.equals(method) || PUT.equals(method)) { -

Re: [jclouds] Work around mockwebserver hangs in S3 tests (#502)

2014-09-30 Thread Andrew Phillips
@adriancole Seeing as you seem to be online...ping? ;-) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/502#issuecomment-57419450

Re: [jclouds] Work around mockwebserver hangs in S3 tests (#502)

2014-09-30 Thread Adrian Cole
I don't think it is a good idea to revert the fixedlengthstreaming mode. I can see how I could have left a comment more descriptive than urlconnection will screw up if we don't do this, but if need be I can dig more into what the original issue with this was. best I can recall, it was a jdk 6

Re: [jclouds] Work around mockwebserver hangs in S3 tests (#502)

2014-09-30 Thread Adrian Cole
@@ -280,7 +280,6 @@ protected void writeNothing(HttpURLConnection connection) { // HttpUrlConnection strips Content-Length: 0 without setDoOutput(true) String method = connection.getRequestMethod(); if (POST.equals(method) || PUT.equals(method)) { -

Re: [jclouds] Work around mockwebserver hangs in S3 tests (#502)

2014-09-26 Thread Andrew Phillips
@@ -280,7 +280,6 @@ protected void writeNothing(HttpURLConnection connection) { // HttpUrlConnection strips Content-Length: 0 without setDoOutput(true) String method = connection.getRequestMethod(); if (POST.equals(method) || PUT.equals(method)) { -

Re: [jclouds] Work around mockwebserver hangs in S3 tests (#502)

2014-09-07 Thread Andrew Gaul
We need to find a way forward on these MWS hangs. Either disable the suspect test temporarily or push forward with this commit. Any preference? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/502#issuecomment-54778403

Re: [jclouds] Work around mockwebserver hangs in S3 tests (#502)

2014-09-05 Thread Andrew Phillips
@adriancole Ping? ;-) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/502#issuecomment-54694735

Re: [jclouds] Work around mockwebserver hangs in S3 tests (#502)

2014-09-02 Thread BuildHive
[jclouds ยป jclouds #1579](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1579/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub:

Re: [jclouds] Work around mockwebserver hangs in S3 tests (#502)

2014-09-02 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #1134](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1134/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/502#issuecomment-54115165

Re: [jclouds] Work around mockwebserver hangs in S3 tests (#502)

2014-09-02 Thread Andrew Phillips
@@ -280,7 +280,6 @@ protected void writeNothing(HttpURLConnection connection) { // HttpUrlConnection strips Content-Length: 0 without setDoOutput(true) String method = connection.getRequestMethod(); if (POST.equals(method) || PUT.equals(method)) { -

[jclouds] Work around mockwebserver hangs in S3 tests (#502)

2014-09-01 Thread Andrew Gaul
Previously S3ClientMockTest.testZeroLengthPutHasContentLengthHeader would hang in MWS at: at java.io.BufferedInputStream.read(BufferedInputStream.java:265) - locked lt;0xd6d8fd60gt; (a java.io.BufferedInputStream) at

Re: [jclouds] Work around mockwebserver hangs in S3 tests (#502)

2014-09-01 Thread Andrew Gaul
Tested with 100 iterations of: `S3ClientMockTest.testZeroLengthPutHasContentLengthHeader`. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/502#issuecomment-54111810

Re: [jclouds] Work around mockwebserver hangs in S3 tests (#502)

2014-09-01 Thread CloudBees pull request builder plugin
[jclouds-pull-requests-java-6 #45](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/45/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/502#issuecomment-54111870