Re: [jclouds-karaf] Added support for the DigitalOcean provider (#39)

2014-03-18 Thread Andrew Phillips
Commit is [here](https://git-wip-us.apache.org/repos/asf?p=jclouds-karaf.git;a=commit;h=176deecd8e3f98165c41c6d72055b597ac0ed3d0) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/39#issuecomment-37957108

Re: [jclouds-karaf] Added support for the DigitalOcean provider (#39)

2014-03-18 Thread Ignasi Barrera
Squashed, rebased and merged. Many thanks @demobox and @iocanel ! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/39#issuecomment-37909638

Re: [jclouds-karaf] Added support for the DigitalOcean provider (#39)

2014-03-18 Thread Ignasi Barrera
Closed #39. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/39

Re: [jclouds-karaf] Added support for the DigitalOcean provider (#39)

2014-03-17 Thread BuildHive
[jclouds » jclouds-karaf #809](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-karaf/809/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pu

Re: [jclouds-karaf] Added support for the DigitalOcean provider (#39)

2014-03-17 Thread Andrew Phillips
> jclouds » jclouds-karaf #808 ABORTED I think this might have been an old build, too: ``` Tests run: 37, Failures: 36, Errors: 0, Skipped: 1 Build was aborted Putting comment on the pull request Finished: ABORTED ``` > jclouds-karaf-pull-requests #51 UNSTABLE No [test failures](https://jclouds

Re: [jclouds-karaf] Added support for the DigitalOcean provider (#39)

2014-03-17 Thread CloudBees pull request builder plugin
[jclouds-karaf-pull-requests #51](https://jclouds.ci.cloudbees.com/job/jclouds-karaf-pull-requests/51/) UNSTABLE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/39#issuecomment-37844960

Re: [jclouds-karaf] Added support for the DigitalOcean provider (#39)

2014-03-17 Thread BuildHive
[jclouds » jclouds-karaf #808](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-karaf/808/) ABORTED [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/39#issuecomment-37843451

Re: [jclouds-karaf] Added support for the DigitalOcean provider (#39)

2014-03-17 Thread Andrew Phillips
> jclouds-karaf-pull-requests #50 ABORTED That was the old PR build. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/39#issuecomment-37839816

Re: [jclouds-karaf] Added support for the DigitalOcean provider (#39)

2014-03-17 Thread CloudBees pull request builder plugin
[jclouds-karaf-pull-requests #50](https://jclouds.ci.cloudbees.com/job/jclouds-karaf-pull-requests/50/) ABORTED --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/39#issuecomment-37839741

Re: [jclouds-karaf] Added support for the DigitalOcean provider (#39)

2014-03-17 Thread Ignasi Barrera
Reverted the last commit and invoked the mirror job. It should trigger again the build, and eventually have it fixed! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/39#issuecomment-37838122

Re: [jclouds-karaf] Added support for the DigitalOcean provider (#39)

2014-03-17 Thread Andrew Phillips
The other test build is also unhappy with 76bb055: `` karaf@root> 183111 [main] ERROR org.ops4j.pax.exam.junit.JUnit4TestRunner - Exception java.lang.RuntimeException: Cannot get the remote bundle context at org.ops4j.pax.exam.rbc.client.intern.RemoteBundleContextClientImpl.getRemoteBundl

Re: [jclouds-karaf] Added support for the DigitalOcean provider (#39)

2014-03-17 Thread Andrew Phillips
> If you are OK, though, this afternoon I'll merge it including the last commit > or not, depending on that > last build result. OK. Also running another test build with the last commit without using the PR builder job: https://jclouds.ci.cloudbees.com/view/integrations/job/jclouds-karaf-do17x

Re: [jclouds-karaf] Added support for the DigitalOcean provider (#39)

2014-03-17 Thread Ignasi Barrera
Once it finishes, clean the workspace and close/reopen the PR again to trigger again the build. If you are OK, though, this afternoon I'll merge it including the last commit or not, depending on that last build result. --- Reply to this email directly or view it on GitHub: https://github.com/jcl

Re: [jclouds-karaf] Added support for the DigitalOcean provider (#39)

2014-03-17 Thread Andrew Phillips
Based on the other test run, I'm good to commit the PR as at 756b0dd (i.e. without 76bb055). I'm really curious why the PR build isn't happy...something to do with the merging, perhaps? Really no idea. I'll clean the workspace, though. --- Reply to this email directly or view it on GitHub: htt

Re: [jclouds-karaf] Added support for the DigitalOcean provider (#39)

2014-03-17 Thread Andrew Phillips
Eek...lots of things going bang in the PR build now: ``` Apache Karaf (2.2.7) Hit '' for a list of available commands and '[cmd] --help' for help on a specific command. Hit '' or 'osgi:shutdown' to shutdown Karaf. karaf@root> Exception in thread "JMX Connector Thread [service:jmx:rmi://0.0.0.0

Re: [jclouds-karaf] Added support for the DigitalOcean provider (#39)

2014-03-17 Thread Andrew Phillips
Actually, we may not even need that. The [test build](https://jclouds.ci.cloudbees.com/view/integrations/job/jclouds-karaf-do17x/1/console) I ran (before the last commit, notice) is already happy: ``` Checking out Revision 756b0dde5e78be5528c53df2f5dd89530fd2140e (origin/do17x) ... karaf@root> fe

Re: [jclouds-karaf] Added support for the DigitalOcean provider (#39)

2014-03-17 Thread Ignasi Barrera
Ok, we have the last change in place. Let's see if it makes the build happy! :) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/39#issuecomment-37827937

Re: [jclouds-karaf] Added support for the DigitalOcean provider (#39)

2014-03-17 Thread Ignasi Barrera
Thanks for the pointers @iocanel! I'm building it locally right now and will push the missing bit in few minutes. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/39#issuecomment-37826845

Re: [jclouds-karaf] Added support for the DigitalOcean provider (#39)

2014-03-17 Thread Andrew Phillips
We should already have ``` ${maven.repo.local} ``` but I guess the other change is still missing. Thanks, @iocanel! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/39#issuecomment-37825566

Re: [jclouds-karaf] Added support for the DigitalOcean provider (#39)

2014-03-17 Thread Ioannis Canellos
@demobox: It's not enough to have the artefact in the local repo. We also need to make sure that we tell karaf were too look. We need https://github.com/jclouds/jclouds-karaf/commit/f212c9177a47bf6cbf2c10484652d565351c#diff-7c886e8267b3c8c3fc641c991371ed33R100 and https://github.com/jclou

Re: [jclouds-karaf] Added support for the DigitalOcean provider (#39)

2014-03-17 Thread Andrew Phillips
Also running this in a separate job to see if this failure is reproducible: https://jclouds.ci.cloudbees.com/view/integrations/job/jclouds-karaf-do17x/1/console --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/39#issuecomment-37824227

Re: [jclouds-karaf] Added support for the DigitalOcean provider (#39)

2014-03-17 Thread Andrew Phillips
> jclouds-karaf-pull-requests #49 UNSTABLE Hm. [Same failure](https://jclouds.ci.cloudbees.com/job/jclouds-karaf-pull-requests/org.apache.jclouds.karaf$itests/49/testReport/org.jclouds.karaf.itests/MiscFeaturesInstallationTest/testDigitalOceanFeature_MiscFeaturesInstallationTest_testDigitalOceanF

Re: [jclouds-karaf] Added support for the DigitalOcean provider (#39)

2014-03-17 Thread CloudBees pull request builder plugin
[jclouds-karaf-pull-requests #49](https://jclouds.ci.cloudbees.com/job/jclouds-karaf-pull-requests/49/) UNSTABLE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/39#issuecomment-37821204

Re: [jclouds-karaf] Added support for the DigitalOcean provider (#39)

2014-03-17 Thread Andrew Phillips
Ioannis is alive!!! Yay ;-) Thanks for explaining, @iocanel! If I understand correctly, @nacx's suggestion of adding `maven.repo.local` seems to be the right one..? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/39#issuecomment-37821175

Re: [jclouds-karaf] Added support for the DigitalOcean provider (#39)

2014-03-17 Thread Ioannis Canellos
@demobox @nacx: Due to the way the maven repo is set on CloudBees, we need to tell the karaf instance that is used in the integration tests, where to find the local maven repo. The other thing that we need to do is to ensure that all the required artefacts are inside that repo. So we need to:

Re: [jclouds-karaf] Added support for the DigitalOcean provider (#39)

2014-03-17 Thread Andrew Phillips
> Do you think we can just go ahead and get it merged, or better try adding > only the > maven.repo.local to the itests pom and see if that fixes the tests? It's weird, because after all only _one_ test is failing. Could you try adding `maven.repo.local` to see if that makes any difference? If

Re: [jclouds-karaf] Added support for the DigitalOcean provider (#39)

2014-03-17 Thread Ignasi Barrera
@demobox to make the CloudBees build happy, it seems we'd have to backport https://github.com/jclouds/jclouds-karaf/commit/f212c9177a47bf6cbf2c10484652d565351c too, but it upgrades Karaf from 2.2.7 to 2.3.2. Do you think we can just go ahead and get it merged, or better try adding only the `

Re: [jclouds-karaf] Added support for the DigitalOcean provider (#39)

2014-03-16 Thread BuildHive
[jclouds » jclouds-karaf #805](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-karaf/805/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pu

Re: [jclouds-karaf] Added support for the DigitalOcean provider (#39)

2014-03-16 Thread CloudBees pull request builder plugin
[jclouds-karaf-pull-requests #48](https://jclouds.ci.cloudbees.com/job/jclouds-karaf-pull-requests/48/) UNSTABLE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/39#issuecomment-37775327

[jclouds-karaf] Added support for the DigitalOcean provider (#39)

2014-03-16 Thread Ignasi Barrera
You can merge this Pull Request by running: git pull https://github.com/jclouds/jclouds-karaf do17x Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-karaf/pull/39 -- Commit Summary -- * Added support for the DigitalOcean provider -- File Changes