Closed #153.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/153#event-274544786
Pushed to master and 1.9.x. Thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/153#issuecomment-90243519
@nacx Last rebuilt was successful :-)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/153#issuecomment-88836620
Thanks @ilgrosso! Looks like an unrelated build failure. let's trigger the
build again: rebuild please!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/153#issuecomment-88831230
Rebuild, please.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/153#issuecomment-88811282
@nacx I've carried out the refactoring suggested, please have a look.
FYI at the end I've removed completely the dependency on BouncyCastle.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/153#issuecomment-88778852
> @@ -56,6 +56,11 @@
>${project.parent.version}
>
>
> + org.apache.jclouds.driver
> + jclouds-sshj
> + ${project.parent.version}
Without `jclouds-sshj` I don't have classes like as
`org.bouncycastle.openssl.PEMKeyPair`, `org.bouncycastle.openssl.PEMParser` and
> @@ -56,6 +56,11 @@
>${project.parent.version}
>
>
> + org.apache.jclouds.driver
> + jclouds-sshj
> + ${project.parent.version}
We shouldn't force users to a concrete SSH driver. Wouldn't be enough to just
add the BouncyCastle driver dependency? Can we get rid
The credentials supplier does many things. I'd refactor it in a "delegating
credential supplier" and extract the two branches of the conditional into a
"FileBasedSupplier" and an "InMemorySupplier". Inject both suppliers into the
delegating one and pick the right one based on the type of the pro
... and private key
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/153
-- Commit Summary --
* [JCLOUDS-838] Introducing InMemoryKeyManager for PEM-encoded certificate
and private key
-- File Changes --
M azurecompute/pom.xm
10 matches
Mail list logo
