Pushed to master as
[80f5c8f](https://git-wip-us.apache.org/repos/asf?p=jclouds-labs.git;a=commit;h=80f5c8f763f731437ba68986b7d9837900544334).
Thanks @hsbhathiya!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/126#issuecomment-72473575
Closed #126.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/126#event-228562208
@nacx I made that change
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/126#issuecomment-72278436
> +import com.google.common.collect.ImmutableList.Builder;
> +import com.google.inject.Inject;
> +import org.jclouds.azurecompute.domain.DataVirtualHardDisk;
> +import org.jclouds.http.functions.ParseSax;
> +import org.xml.sax.Attributes;
> +
> +import java.util.List;
> +
> +public final class List
@hsbhathiya One last minor comment. I'll merge it once addressed. Thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/126#issuecomment-72180220
@nacx I addressed those issues you mentioned. can we merge this?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/126#issuecomment-72078688
> + * limitations under the License.
> + */
> +package org.jclouds.azurecompute.xml;
> +
> +import com.google.common.collect.ImmutableList;
> +import com.google.common.collect.ImmutableList.Builder;
> +import org.jclouds.azurecompute.domain.DataVirtualHardDisk;
> +import org.jclouds.http.functions.
> +import com.google.auto.value.AutoValue;
> +import org.jclouds.javax.annotation.Nullable;
> +
> +import java.net.URI;
> +
> +/**
> + * @see href="https://msdn.microsoft.com/en-us/library/azure/jj157193.aspx#DataVirtualHardDisks";
> >api
> + */
> +
> +@AutoValue
> +public abstract class DataVirt
@andreaturli I have corected the pointed out mistakes. Shall we merge this?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/126#issuecomment-71612637
@andreaturli I corrected those mistakes
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/126#issuecomment-71242283
> +
> + /**
> +* Required if an existing disk is being used to create a Virtual Machine.
> +* Specifies the name of a new or existing disk
> +*/
> + @Nullable public abstract String diskName();
> +
> + /**
> +* Specifies the Logical Unit Number (LUN) for the data disk. If the
> +* If the disk that is being added is already registered in the
> subscription or the VHD for the disk already exists
> +* in blob storage, this element is ignored. If a VHD file does not exist
> in blob storage, this element defines the
> +* location of the new VHD that is created
@andreaturli Can you review this?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/126#issuecomment-71131095
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/126
-- Commit Summary --
* JCLOUDS-664: Added DataVirtualHardDisk Representation With Tests
-- File Changes --
A
azurecompute/src/main/java/org/jclouds/azurecompute/domain/Dat
14 matches
Mail list logo
