This PR wil be splited into few smaller PRs
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/124#issuecomment-70675770
Closed #124.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/124#event-221678548
@andreaturli Thanks for quick response. I made
https://github.com/jclouds/jclouds-labs/pull/125
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/124#issuecomment-70675258
thanks for that @hsbhathiya!
Btw, it is a bit hard to review this PR all together, can you maybe split it
into multiple PRs.
In fact, the code looks ok, but I'd like to have time to look at the official
Azure documentation to see if the Value objects cover the spec correctly. Just
to give you an
> import com.google.common.collect.ImmutableSet;
>
> @Test(groups = "live", testName = "OSImageApiLiveTest")
> public class OSImageApiLiveTest extends BaseAzureComputeApiLiveTest {
>
> - private ImmutableSet locations;
why did you remove this check from the test?
---
Reply to this email
> + * distributed under the License is distributed on an "AS IS" BASIS,
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> + * See the License for the specific language governing permissions and
> + * limitations under the License.
> + */
> +package org.jclouds.azureco
> + *
> + * Unless required by applicable law or agreed to in writing, software
> + * distributed under the License is distributed on an "AS IS" BASIS,
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> + * See the License for the specific language governing permission
@andreaturli I made chnges to the azure deploy. can you review this?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/124#issuecomment-70632714
Added OSVHD and DataVHD
Changes in Role
Added IOTypes
JCLOUDS-664:Azure Role representation
Role Instance handler with tests
JCLOUDS-664: Implemented Azure Role represenstaion
Added OSVHD and DataVHD
Changes in Role
Added IOTypes
JCLOUDS-664:Azure Role representation
Added VHD Handlers
C
