Re: [jclouds-labs] JCLOUDS-664: Implemented Role represenstaion in API (#118)

2015-03-24 Thread Everett Toews
Thanks for the pull request but it's release week in jclouds and that means it's time to clean up the PR queue. This PR will be over 6 months old as of April 1. If you intend to continue work on it, please make a comment by April 2. Otherwise it will be closed on April 3. --- Reply to this emai

Re: [jclouds-labs] JCLOUDS-664: Implemented Role represenstaion in API (#118)

2014-12-22 Thread Andrea Turli
Also, I know about your roadmap and I'd suggest you to not focus on this translator during Milestone 1. In fact, the first thing to do IMO is to finalise the `features` API and all the `domain` objects managed by those API. Once you get those right, it would be straightforward to finalise the A

Re: [jclouds-labs] JCLOUDS-664: Implemented Role represenstaion in API (#118)

2014-12-22 Thread Andrea Turli
As rule of thumb, better to open PR at the time, so we can help you more. do u really think Role is really needed? If yes, where? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/118#issuecomment-67872617

Re: [jclouds-labs] JCLOUDS-664: Implemented Role represenstaion in API (#118)

2014-12-22 Thread Bhathiya
@andreaturli I'll be working on review suggeations in previous PR (https://github.com/jclouds/jclouds-labs/pull/118). As I undertand "RoleSizeToHarware" in current implementation should be chanegd to "RoleToHardware". P.S.:Tried to contact you over irc. But got some issues with my internet c

[jclouds-labs] JCLOUDS-664: Implemented Role represenstaion in API (#118)

2014-12-22 Thread Bhathiya
Added OSVHD and DataVHD Changes in Role Added IOTypes JCLOUDS-664:Azure Role representation You can merge this Pull Request by running: git pull https://github.com/hsbhathiya/jclouds-labs azure_m1_v2 Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds