Re: [jclouds-labs] JCLOUDS-664: OSVirtualHardDisk Support With Tests (#125)

2015-01-22 Thread Bhathiya
@andreaturli Thanks.I added https://github.com/jclouds/jclouds-labs/pull/126 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/125#issuecomment-71021138

Re: [jclouds-labs] JCLOUDS-664: OSVirtualHardDisk Support With Tests (#125)

2015-01-22 Thread Andrea Turli
lgtm! thanks @hsbhathiya --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/125#issuecomment-70991125

Re: [jclouds-labs] JCLOUDS-664: OSVirtualHardDisk Support With Tests (#125)

2015-01-21 Thread Bhathiya
> + > +/** > + * @see href="http://msdn.microsoft.com/en-us/library/azure/jj157186.aspx#OSVirtualHardDisk"; > >api > + */ > +@AutoValue > +public abstract class OSVirtualHardDisk { > + > + /** > +* Specifies the caching mode of the operating system disk. > +* This setting impacts the co

Re: [jclouds-labs] JCLOUDS-664: OSVirtualHardDisk Support With Tests (#125)

2015-01-21 Thread Andrea Turli
> + > +/** > + * @see href="http://msdn.microsoft.com/en-us/library/azure/jj157186.aspx#OSVirtualHardDisk"; > >api > + */ > +@AutoValue > +public abstract class OSVirtualHardDisk { > + > + /** > +* Specifies the caching mode of the operating system disk. > +* This setting impacts the co

Re: [jclouds-labs] JCLOUDS-664: OSVirtualHardDisk Support With Tests (#125)

2015-01-21 Thread Bhathiya
@andreaturli can we merge this? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/125#issuecomment-70852529

Re: [jclouds-labs] JCLOUDS-664: OSVirtualHardDisk Support With Tests (#125)

2015-01-20 Thread Andrea Turli
> + * > + * Unless required by applicable law or agreed to in writing, software > + * distributed under the License is distributed on an "AS IS" BASIS, > + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > + * See the License for the specific language governing permission

Re: [jclouds-labs] JCLOUDS-664: OSVirtualHardDisk Support With Tests (#125)

2015-01-20 Thread Bhathiya
@andreaturli Sorry, there is a mistake in the refference link. It Should be http://msdn.microsoft.com/en-us/library/azure/ee460804.aspx#OSVirtualHardDisk I'll correct it. I mapped http://msdn.microsoft.com/en-us/library/azure/jj157186.aspx#OSVirtualHardDisk to OSVirtualHardDiskParam (not in t

Re: [jclouds-labs] JCLOUDS-664: OSVirtualHardDisk Support With Tests (#125)

2015-01-20 Thread Andrea Turli
@hsbhathiya thanks for splitting the PR, it is now way easier to review! There are just some comments to get the Value class right, according to the online doc, at least. Please revisit the impl, and commit the changes. Once we'll be happy with the PR, we will squash the commits into just one c

Re: [jclouds-labs] JCLOUDS-664: OSVirtualHardDisk Support With Tests (#125)

2015-01-20 Thread Andrea Turli
> @@ -0,0 +1,11 @@ > +http://schemas.microsoft.com/windowsazure";> > +ReadOnly > +MyTestImage_1 > +testosimage1-testosimage1-0-20120817095145 > + > http://blobs/disks/neotysss/MSFT__Win2K8R2SP1-ABCD-en-us-30GB.vhd > +Ubuntu Server 12.04 LTS > +linux > +30 > + > http:

Re: [jclouds-labs] JCLOUDS-664: OSVirtualHardDisk Support With Tests (#125)

2015-01-20 Thread Andrea Turli
> +* in Windows Azure. If you specify the path to an image with this > element, an associated VHD is created and > +* you must use the MediaLink element to specify the location in storage > where the VHD will be located. > +* If this element is used, SourceImageName is not used. > +

Re: [jclouds-labs] JCLOUDS-664: OSVirtualHardDisk Support With Tests (#125)

2015-01-20 Thread Andrea Turli
> +/** > + * @see href="http://msdn.microsoft.com/en-us/library/azure/jj157186.aspx#OSVirtualHardDisk"; > >api > + */ > +@AutoValue > +public abstract class OSVirtualHardDisk { > + > + /** > +* Specifies the caching mode of the operating system disk. > +* This setting impacts the consis

Re: [jclouds-labs] JCLOUDS-664: OSVirtualHardDisk Support With Tests (#125)

2015-01-20 Thread Andrea Turli
> + > +/** > + * @see href="http://msdn.microsoft.com/en-us/library/azure/jj157186.aspx#OSVirtualHardDisk"; > >api > + */ > +@AutoValue > +public abstract class OSVirtualHardDisk { > + > + /** > +* Specifies the caching mode of the operating system disk. > +* This setting impacts the co

[jclouds-labs] JCLOUDS-664: OSVirtualHardDisk Support With Tests (#125)

2015-01-20 Thread Bhathiya
Changes in Deployment Representation - Part 1 You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/125 -- Commit Summary -- * JCLOUDS-664: OSVirtualHardDisk Support With Tests -- File Changes -- A azurecompute/src/main/java/org/j