This PR includes code that is already in master, and it is quite hard to
review. Can you please rebase it to the latest master version?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/134#issuecomment-74840815
I think the starting point of this PR is not the right one, as I see some merge
commits there too. If you have a look at the modified files in the PR, you will
see *many* files that are not related to the changes for the SnapshotApi. There
is the entire pom.xml that appears as changed, the
@nacx We're forked from a fork. We're going to re-do our repo, the branch, and
then re-send a new PR with meeting hopefully your requirements. We're not sure
how to clean it up otherwise. This is work we're doing in tandem with another
user.
---
Reply to this email directly or view it on
Closed #134.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/134#event-237827778
@nacx I've just rebased to the latest master version.
Did I miss anything?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/134#issuecomment-74895426
@nacx Hi, we've been working on this with RJ. We have the PR passing tests so
we're just waiting on a review to merge. Let me know if there are any issues or
changes that need to happen. Thanks.
---
Reply to this email directly or view it on GitHub:
Hi All:
Here's a pull request to surface the snapshot capabilities within jClouds Labs
for the ProfitBricks provider. We are working in conjunction with @devcsrj .
Please let us know if there are any questions or issues.
Thanks.
-matt
You can view, comment on, or merge this pull request
