Closed #165.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/165#event-365790610
Ok @cdancy. Thanks for all the good work you've put in this provider!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/165#issuecomment-125109191
@nacx we can remove this PR. Project is more/less dead and I've just submitted
a PR to remove it from jclouds-labs.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/165#issuecomment-124882951
+ public abstract RoleInfo role();
+
+ CreateAccount() {
+ }
+
+ @SerializedNames({ username, password, role})
+ public static CreateAccount create(String username, String password,
RoleInfo role) {
+ checkArgument(username.length() 0, username must not be empty
+ public abstract RoleInfo role();
+
+ CreateAccount() {
+ }
+
+ @SerializedNames({ username, password, role})
+ public static CreateAccount create(String username, String password,
RoleInfo role) {
+ checkArgument(username.length() 0, username must not be empty
+ public abstract String password();
+
+ public abstract RoleInfo role();
+
+ CreateAccount() {
+ }
+
+ @SerializedNames({ username, password, role})
+ public static CreateAccount create(String username, String password,
RoleInfo role) {
+
Just one very minor. Mind addressing it and squash the commits to we can
cleanly merge this? Thanks @cdancy!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/165#issuecomment-99050831
+ public abstract String password();
+
+ public abstract RoleInfo role();
+
+ CreateAccount() {
+ }
+
+ @SerializedNames({ username, password, role})
+ public static CreateAccount create(String username, String password,
RoleInfo role) {
+
+ public abstract String password();
+
+ public abstract RoleInfo role();
+
+ CreateAccount() {
+ }
+
+ @SerializedNames({ username, password, role})
+ public static CreateAccount create(String username, String password,
RoleInfo role) {
+
@nacx comments have been addressed and things look good on my end. Now that
JCLOUDS-886 has been merged we are good to go here. This is the last piece of
work I wanted to get in before tackling the compute API.
---
Reply to this email directly or view it on GitHub:
+public abstract class CreateAccount {
+
+ public abstract String username();
+
+ public abstract String password();
+
+ public abstract CreateRole role();
+
+ CreateAccount() {
+ }
+
+ @SerializedNames({ username, password, role})
+ public static CreateAccount
+
+ public void testCreateAccount() throws Exception {
+ api().createAccount(CreateAccount.create(username, password, null));
+ }
+
+ @Test (dependsOnMethods = testCreateAccount)
+ public void testListAccounts() throws Exception {
+ ListAccountInfo possibleAccounts =
+import org.jclouds.shipyard.domain.accounts.AccountInfo;
+import org.jclouds.shipyard.domain.accounts.CreateAccount;
+import org.jclouds.shipyard.internal.BaseShipyardApiLiveTest;
+import org.testng.annotations.AfterClass;
+import org.testng.annotations.Test;
+
+@Test(groups = live,
Thanks @cdancy!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/165#issuecomment-93317048
@nacx let's please merge PR 166 before this as the Accounts API has a minor
dependency on the Roles API. Both are fairly simple and straight forward so I
don't imagine too much churn.
---
Reply to this email directly or view it on GitHub:
15 matches
Mail list logo
