Thanks @danbroudy for helping us close that!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/69#issuecomment-61310875
Closed #69.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/69#event-186337335
merged to master. Thanks tons!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/69#issuecomment-61203612
On the master branch before these changes there are currently 4 live test
failures when I run them.
I am experiencing the same 4 failures when I run the tests with this PRs
changes.
These test failures are also nothing new. I reported them on the JIRA at
[JCLOUDS-755](https://issues.apache.org/
[jclouds » jclouds-labs-google
#1592](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1592/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jc
[jclouds » jclouds-labs-google
#1591](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1591/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jc
[jclouds-labs-google-pull-requests
#195](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/195/)
UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/69#issueco
[jclouds-labs-google-pull-requests
#194](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/194/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/69#issuecomment-61138953
I'll probably help @nacx convert this project to auto value and simplify a lot
of the serialization logic. As this pull request is put together now, provided
live tests work, etc. I'm ok merging. Should be squashed, though.
---
Reply to this email directly or view it on GitHub:
https://github.co
> +import com.google.common.annotations.Beta;
> +import com.google.common.base.Objects;
> +import com.google.common.base.Optional;
> +
> +import java.beans.ConstructorProperties;
> +import java.net.URI;
> +import java.util.Date;
> +
> +import static com.google.common.base.Objects.equal;
> +import s
[jclouds » jclouds-labs-google
#1582](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1582/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jc
[jclouds-labs-google-pull-requests
#190](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/190/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/69#issuecomment-61033161
[jclouds » jclouds-labs-google
#1580](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1580/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jc
[jclouds-labs-google-pull-requests
#189](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/189/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/69#issuecomment-61030663
[jclouds » jclouds-labs-google
#1576](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1576/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jc
I would also be fine to take measures to decrease the size of this commit by
removing renames and comment edits. Many were done in response to comments in
#22 but they significantly increase the number of effected files.
---
Reply to this email directly or view it on GitHub:
https://github.com/
[jclouds-labs-google-pull-requests
#188](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/188/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/69#issuecomment-60972957
Thanks to @andreaturli for kicking this off in PR #22
This isn't ready yet but I wanted to seek comments on the TargetPoolApi and
associated TargetPoolCreationOptions.
There is redundancy between the TargetPoolCreationOptions and the TargetPool
resource class. I have taken the rout of having
18 matches
Mail list logo