Re: [jclouds-labs-google] JCLOUDS-740 GCE doesn't always return id, selfLink on lists. (#50)

2014-10-03 Thread Adrian Cole
Closed #50. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/50#event-174064587

Re: [jclouds-labs-google] JCLOUDS-740 GCE doesn't always return id, selfLink on lists. (#50)

2014-10-03 Thread Adrian Cole
merged --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/50#issuecomment-57873547

Re: [jclouds-labs-google] JCLOUDS-740 GCE doesn't always return id, selfLink on lists. (#50)

2014-10-03 Thread Chris Custine
:+1: on merging this anyway. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/50#issuecomment-57871826

Re: [jclouds-labs-google] JCLOUDS-740 GCE doesn't always return id, selfLink on lists. (#50)

2014-10-03 Thread Adrian Cole
Thanks for the update. FWIW, I think we should proceed with this change anyway. There's no real value exposed in having these fields, and this change makes the ListPage classes more consistent across compute, storage. sg? p.s. I will take you up, but maybe with coconut water :) --- Reply to this

Re: [jclouds-labs-google] JCLOUDS-740 GCE doesn't always return id, selfLink on lists. (#50)

2014-10-03 Thread danbroudy
We followed up on this on the inside and looks like this is a bug that will be rolled back soon. erjohnso and I say beers on us next time you are in Seattle. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/50#issuecomment-57834250

Re: [jclouds-labs-google] JCLOUDS-740 GCE doesn't always return id, selfLink on lists. (#50)

2014-10-03 Thread Eric Johnson
/cc @danbroudy - this sounds pretty similar to what we saw yesterday. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/50#issuecomment-57783517

Re: [jclouds-labs-google] JCLOUDS-740 GCE doesn't always return id, selfLink on lists. (#50)

2014-10-02 Thread CloudBees pull request builder plugin
[jclouds-labs-google-pull-requests #145](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/145/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/50#issuecomment-57743408

Re: [jclouds-labs-google] JCLOUDS-740 GCE doesn't always return id, selfLink on lists. (#50)

2014-10-02 Thread BuildHive
[jclouds ยป jclouds-labs-google #1382](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1382/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jc

[jclouds-labs-google] JCLOUDS-740 GCE doesn't always return id, selfLink on lists. (#50)

2014-10-02 Thread Adrian Cole
The extra fields on ListPage were causing NPEs as they were expected present. There's no value in id, selfLink on a list anyway. While working on this, I noticed we were backing an Iterable with a Set. It is cheaper to do this with a List, so I switched it. You can merge this Pull Request by run