> +import org.jclouds.rest.AuthorizationException;
> +
> +import com.google.common.base.Function;
> +import com.google.common.base.Supplier;
> +import com.google.common.collect.ImmutableList;
> +
> +public final class ClaimsToAssertion implements Function {
> + private static final List SUPPORTED
> - expirationSeconds = expirationSeconds > 30 ? expirationSeconds - 30 :
> expirationSeconds;
> - return CacheBuilder.newBuilder().expireAfterWrite(expirationSeconds,
> SECONDS).build(CacheLoader.from(getAccess));
> - }
> -
> - /**
> -* Defers instantiation of {@linkplain SignO
Just a couple of minor comments. +1 - looks good to me. Thanks, @adriancole!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/96#issuecomment-63563273
> +import org.jclouds.rest.AuthorizationException;
> +
> +import com.google.common.base.Function;
> +import com.google.common.base.Supplier;
> +import com.google.common.collect.ImmutableList;
> +
> +public final class ClaimsToAssertion implements Function {
> + private static final List SUPPORTED
> @Provides
> - @Singleton
> - public LoadingCache
> provideAccessCache(Function getAccess,
> -
> @Named(PROPERTY_SESSION_INTERVAL) long expirationSeconds) {
> - // since the session interval is also the token expiration t
> @Provides
> - @Singleton
> - public LoadingCache
> provideAccessCache(Function getAccess,
> -
> @Named(PROPERTY_SESSION_INTERVAL) long expirationSeconds) {
> - // since the session interval is also the token expiration t
Closed #96.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/96#event-195048816
and.. in
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/96#issuecomment-63522384
GCE tests were doing fine, then I screwed up my classpath working on something
unrelated about 30m in. I'm going to merge, and certainly run live tests again
on next change
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/96#issuecomment-
similar error ratio on google storage
```
Tests run: 101, Failures: 7, Errors: 0, Skipped: 55
```
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/96#issuecomment-63514650
Live test from oauth passed
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/96#issuecomment-63513431
I'd like to see the LiveTests result to +1 unless @nacx @ccustine have other
thoughts
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/96#issuecomment-63509637
Simplifications are made around JWT actually, not necessarily google. For
example, I used salesforce docs to clarify terminology!
https://help.salesforce.com/HTViewHelpDoc?id=remoteaccess_oauth_jwt_flow.htm
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-
don't have a way to run LiveTests, can you report the result from your tests?
If they are ok, I think the assumptions done to simplify the implementation are
ok for Google's product. If we then want to support OAuth for other providers
will probably need to revisit that again, correct?
---
Repl
> @@ -35,7 +35,7 @@
> import
> org.jclouds.googlecloudstorage.domain.templates.BucketAccessControlsTemplate;
> import org.jclouds.http.HttpResponse;
> import org.jclouds.javax.annotation.Nullable;
> -import org.jclouds.oauth.v2.filters.OAuthAuthenticationFilter;
> +import org.jclouds.oauth.v2.f
[jclouds » jclouds-labs-google
#1746](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1746/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jc
[jclouds-labs-google-pull-requests
#302](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/302/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/96#issuecomment-63428398
[jclouds » jclouds-labs-google
#1745](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1745/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jc
[jclouds-labs-google-pull-requests
#301](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/301/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/96#issuecomment-63427590
[jclouds » jclouds-labs-google
#1744](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1744/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jc
>
> import com.google.common.base.Function;
> import com.google.common.base.Joiner;
> import com.google.common.base.Supplier;
>
> /** Builds the default token request with the following claims: {@code
> iss,scope,aud,iat,exp}. */
> -public class BuildTokenRequest implements Function TokenR
> +
> + @Inject ClaimsToAssertion(@Named(JWS_ALG) String alg, @Authorization
> Supplier privateKey, Json json) {
> + this.alg = alg;
> + checkArgument(SUPPORTED_ALGS.contains(alg), "%s %s not in supported
> list", JWS_ALG, alg, SUPPORTED_ALGS);
> + this.privateKey = privateKey;
>
[jclouds-labs-google-pull-requests
#300](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/300/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/96#issuecomment-63426957
and now.. the 1k less lines edition! @ccustine @nacx ptal
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/96#issuecomment-63426892
[jclouds » jclouds-labs-google
#1743](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1743/)
UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https
[jclouds-labs-google-pull-requests
#299](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/299/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/96#issuecomment-63422931
[jclouds » jclouds-labs-google
#1742](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1742/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jc
[jclouds-labs-google-pull-requests
#298](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/298/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/96#issuecomment-63419376
OAuth smoke and mirror indirection is coming to an end. Through tracing code,
I've found that we only actually issue Bearer tokens. I've renamed accordingly,
and flattened a complex cache mapping. There's at least one more cleanup round
to do, but this should be the last api-breaker
TODO for im
29 matches
Mail list logo
