Re: [jclouds-labs-google] Remove creepy and unused extensibility. (#87)

2014-11-12 Thread Adrian Cole
Closed #87. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/87#event-192463355

Re: [jclouds-labs-google] Remove creepy and unused extensibility. (#87)

2014-11-10 Thread Adrian Cole
I'll address this after reworking oauth annotations.. I think. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/87#issuecomment-62419227

Re: [jclouds-labs-google] Remove creepy and unused extensibility. (#87)

2014-11-08 Thread Adrian Cole
@ccustine --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/87#issuecomment-62280979

[jclouds-labs-google] Remove creepy and unused extensibility. (#87)

2014-11-08 Thread Adrian Cole
optional injection is one of the scariest things in guice. we have not needed these extension points in 2 years, so I#39;m guessing we can kill them. You can merge this Pull Request by running: git pull https://github.com/adriancole/jclouds-labs-google adrian.oauth-again Or you can view,

Re: [jclouds-labs-google] Remove creepy and unused extensibility. (#87)

2014-11-08 Thread CloudBees pull request builder plugin
[jclouds-labs-google-pull-requests #257](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/257/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/87#issuecomment-62281040

Re: [jclouds-labs-google] Remove creepy and unused extensibility. (#87)

2014-11-08 Thread BuildHive
[jclouds » jclouds-labs-google #1670](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1670/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub:

Re: [jclouds-labs-google] Remove creepy and unused extensibility. (#87)

2014-11-08 Thread Adrian Cole
public final class BuildTokenRequest implements FunctionGeneratedHttpRequest, TokenRequest { private final String assertionTargetDescription; private final String signatureAlgorithm; private final SupplierOAuthCredentials credentialsSupplier; private final long

Re: [jclouds-labs-google] Remove creepy and unused extensibility. (#87)

2014-11-08 Thread CloudBees pull request builder plugin
[jclouds-labs-google-pull-requests #258](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/258/) UNSTABLE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub:

Re: [jclouds-labs-google] Remove creepy and unused extensibility. (#87)

2014-11-08 Thread Adrian Cole
@@ -67,12 +61,6 @@ .put(ES512, EC) .put(NO_ALGORITHM, NO_ALGORITHM).build(); - /** -* The (optional) set of additional claims to use, provided in MapString,String form -*/ only used in tests, and only in this module --- Reply to this email directly or

Re: [jclouds-labs-google] Remove creepy and unused extensibility. (#87)

2014-11-08 Thread CloudBees pull request builder plugin
[jclouds-labs-google-pull-requests #259](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/259/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/87#issuecomment-62291498

Re: [jclouds-labs-google] Remove creepy and unused extensibility. (#87)

2014-11-08 Thread Adrian Cole
@@ -116,7 +116,8 @@ protected BaseGoogleComputeEngineExpectTest() { @Override public void configure(Binder binder) { // Predictable time -binder.bind(new TypeLiteralSupplierLong() {}).toInstance(Suppliers.ofInstance(0L)); +

Re: [jclouds-labs-google] Remove creepy and unused extensibility. (#87)

2014-11-08 Thread BuildHive
[jclouds » jclouds-labs-google #1672](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1672/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: