Thanks, @jdaggett and @nacx! Added one minor comment, which can perhaps be
addressed in the post-1.7.2 PR that was discussed to change the 404 behaviour?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/89#issuecomment-39649138
> @@ -68,7 +68,16 @@ public void testListWithOptions() throws Exception {
> assertTrue(container.getBytesUsed() == 0);
>}
> }
> -
> +
> + public void testHead() throws Exception {
> + for (String regionId : regions) {
> + Container container = api.containerAp
Merged to master and 1.7.x
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/89#issuecomment-39516488
Closed #89.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/89
@nacx Great! If we are good to go, then I can add those changes to a new PR
post-1.7.2 . I just made a note to remind me about updating the test. :)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/89#issuecomment-39515652
Thanks for the cleanup. I'm OK to change that post 1.7.2 as that behavior was
already there and was not the purpose of this PR. It would be better addressed
in a new one.
Regarding the test that throws the exception and reading it again (my apologies
for not having suggested this before), I thi
[jclouds » jclouds-labs-openstack
#1022](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1022/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclo
[jclouds » jclouds-labs-openstack
#1021](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1021/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclo
@nacx Do you agree with the state of this PR. Are we good to merge?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/89#issuecomment-39508020
> + assertEquals(container.getName(), "myContainer");
> + assertEquals(container.getObjectCount(), 42l);
> + assertEquals(container.getBytesUsed(), 323479l);
> + for (Entry entry :
> container.getMetadata().entrySet()) {
> +
> assertEquals(container.getM
> @@ -80,6 +80,23 @@
> @Fallback(NullOnNotFoundOr404.class)
> @Path("/")
> @Nullable
> + ObjectList list();
> +
> + /**
> +* Lists up to 10,000 objects.
> +*
> +* @param options
> +* the {@link ListContainerOptions} for controlling the
> returned list.
[jclouds-labs-openstack-pull-requests
#215](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/215/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/89#issuecomment-39507714
[jclouds-labs-openstack-pull-requests
#214](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/214/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/89#issuecomment-39506929
> + assertEquals(container.getName(), "myContainer");
> + assertEquals(container.getObjectCount(), 42l);
> + assertEquals(container.getBytesUsed(), 323479l);
> + for (Entry entry :
> container.getMetadata().entrySet()) {
> +
> assertEquals(container.getM
> @@ -80,6 +80,23 @@
> @Fallback(NullOnNotFoundOr404.class)
> @Path("/")
> @Nullable
> + ObjectList list();
> +
> + /**
> +* Lists up to 10,000 objects.
> +*
> +* @param options
> +* the {@link ListContainerOptions} for controlling the
> returned list.
[jclouds-labs-openstack-pull-requests
#209](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/209/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/89#issuecomment-39449580
[jclouds » jclouds-labs-openstack
#1014](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1014/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclo
> @@ -80,6 +80,23 @@
> @Fallback(NullOnNotFoundOr404.class)
> @Path("/")
> @Nullable
> + ObjectList list();
> +
> + /**
> +* Lists up to 10,000 objects.
> +*
> +* @param options
> +* the {@link ListContainerOptions} for controlling the
> returned list.
> +
> + Container container =
> api.containerApiInRegion("DFW").head("myContainer");
> + assertEquals(container.getName(), "myContainer");
> + assertEquals(container.getObjectCount(), 42l);
> + assertEquals(container.getBytesUsed(), 323479l);
> + fo
> +.addHeader(CONTAINER_READ, CONTAINER_ACL_ANYBODY_READ)
> +.setBody(stringFromResource("/object_list.json";
> +
> + try {
> + SwiftApi api = api(server.getUrl("/").toString(),
> "openstack-swift");
> + ObjectList objects = api.objectApiInRegionFor
> @@ -80,6 +80,23 @@
> @Fallback(NullOnNotFoundOr404.class)
> @Path("/")
> @Nullable
> + ObjectList list();
> +
> + /**
> +* Lists up to 10,000 objects.
> +*
> +* @param options
> +* the {@link ListContainerOptions} for controlling the
> returned list.
> +
> + Container container =
> api.containerApiInRegion("DFW").head("myContainer");
> + assertEquals(container.getName(), "myContainer");
> + assertEquals(container.getObjectCount(), 42l);
> + assertEquals(container.getBytesUsed(), 323479l);
> + fo
[jclouds » jclouds-labs-openstack
#1012](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1012/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclo
[jclouds-labs-openstack-pull-requests
#207](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/207/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/89#issuecomment-39396478
> @@ -123,6 +123,18 @@ public void testCopyObject() throws Exception {
> public void testList() throws Exception {
>for (String regionId : regions) {
> ObjectApi objectApi = api.objectApiInRegionForContainer(regionId,
> containerName);
> + ObjectList response = object
[jclouds » jclouds-labs-openstack
#1007](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1007/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclo
[jclouds-labs-openstack-pull-requests
#203](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/203/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/89#issuecomment-39383404
> jclouds-labs-openstack-pull-requests #199 SUCCESS
[Happy
Checkstyle](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/199/violations/)!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/89#issuecomment-3938289
> @@ -123,6 +123,18 @@ public void testCopyObject() throws Exception {
> public void testList() throws Exception {
>for (String regionId : regions) {
> ObjectApi objectApi = api.objectApiInRegionForContainer(regionId,
> containerName);
> + ObjectList response = object
> @@ -80,6 +80,23 @@
> @Fallback(NullOnNotFoundOr404.class)
> @Path("/")
> @Nullable
> + ObjectList list();
> +
> + /**
> +* Lists up to 10,000 objects.
If we're going to list this limitation here, also suggest what to do if you
need to retrieve more items? Is there a differen
Needs a live test for the head() method.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/89#issuecomment-39378402
[jclouds-labs-openstack-pull-requests
#199](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/199/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/89#issuecomment-39364532
This PR removes the dependency on the _varargs_ for the **ObjectApi.list()**
method.
It also adds the **ContainerApi.head()** method to get just the Container
metadata, rather than retrieving the entire object. This method is utilized to
determine if a container exists or not.
This will need
33 matches
Mail list logo
