Merged to
[master](https://git-wip-us.apache.org/repos/asf?p=jclouds-labs-openstack.git;a=commit;h=9e2049dbd1a72922446e832b548e0a102d79d26d).
Thanks for sticking with this!
---
Reply to this email directly or view it on GitHub:
:+1: yay :)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/163#issuecomment-59962019
}
}
- @Test
+ @Test(dependsOnMethods = testCreateUpdateAndDeleteImage)
If this is to make sure the two tests don't step on each other, shouldn't it
just be single-threaded?
---
Reply to this email directly or view it on GitHub:
+ public static String updatedImageName;
+
+ @BeforeClass
+ public void init() {
+ Random random = new Random();
+ imageName = IMAGE_NAME_PREFIX + random.nextInt();
+ updatedImageName = IMAGE_NAME_PREFIX + random.nextInt();
+ }
+
+ @AfterTest
+ public void
Looks good.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/163#issuecomment-59757149
}
}
- @Test
+ @Test(dependsOnMethods = testCreateUpdateAndDeleteImage)
shouldn't it just be single-threaded?
Could do that, but then _no_ tests could run in parallel. But if we feel it's
less confusing, fine with that, too.
---
Reply to this email directly or view it on
}
}
- @Test
+ @Test(dependsOnMethods = testCreateUpdateAndDeleteImage)
How about adding a short comment and keeping dependsOn?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/163/files#r19087293
}
}
- @Test
+ @Test(dependsOnMethods = testCreateUpdateAndDeleteImage)
:+1:
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/163/files#r19091701
@inbarsto @jdaggett @zack-shoylev Does this look OK to you..?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/163#issuecomment-59608798
:+1:
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/163#issuecomment-59617529
master version of https://github.com/jclouds/jclouds-labs-openstack/pull/162
/cc @inbarsto
You can merge this Pull Request by running:
git pull https://github.com/jclouds/jclouds-labs-openstack add-copyimage
Or you can view, comment on it, or merge it online at:
[jclouds-labs-openstack-pull-requests
#465](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/465/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
[jclouds ยป jclouds-labs-openstack
#1845](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1845/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
13 matches
Mail list logo
