About to merge
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/124#issuecomment-51489464
Closed #124.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/124#event-150326368
merged
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/124#issuecomment-51490264
You can merge this Pull Request by running:
git pull https://github.com/rackerlabs/jclouds-labs-openstack
missing-contructorprops
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs-openstack/pull/124
-- Commit Summary --
* Adds missing
[jclouds-labs-openstack-pull-requests
#348](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/348/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
@@ -33,6 +35,7 @@
protected final String start;
protected final String end;
+ @ConstructorProperties({start, end})
Just curious...are these needed? The names look the same?
---
Reply to this email directly or view it on GitHub:
One minor question, but +1 - looks good to me. Thanks, @zack-shoylev!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/124#issuecomment-51208792
@@ -33,6 +35,7 @@
protected final String start;
protected final String end;
+ @ConstructorProperties({start, end})
I am fairly certain that if these are missing GSON will use the unsafe
deserialization approach we want to avoid.
---
Reply to this email directly or view it on
@@ -33,6 +35,7 @@
protected final String start;
protected final String end;
+ @ConstructorProperties({start, end})
Previous investigations of how Gson works (in another PR) showed that, as Zack
points, if the annotation is not present, the default Gson impl will be used to
@zack-shoylev +1 LGTM2!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/124#issuecomment-51265148
@@ -33,6 +35,7 @@
protected final String start;
protected final String end;
+ @ConstructorProperties({start, end})
That was me with the wrong session saved :)
---
Reply to this email directly or view it on GitHub:
@@ -33,6 +35,7 @@
protected final String start;
protected final String end;
+ @ConstructorProperties({start, end})
I am fairly certain that if these are missing GSON will use the unsafe
deserialization approach we want to avoid.
Ah, thanks for explaining! In that case, let's
12 matches
Mail list logo
