+1 - looks good to me, too. Thanks for the updates, @zack-shoylev!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/139#issuecomment-55056740
[jclouds-labs-openstack-pull-requests
#413](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/413/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/139#issuecomment-55015437
merged
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/139#issuecomment-55014427
Closed #139.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/139#event-163242588
About to rebase and merge
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/139#issuecomment-55013556
This seems good to rebase and merge.I will hold off on it for a bit, but would
like to merge and then work on getting neutron backported to 1.8.x today.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/139#issuecomment-54982148
[jclouds-labs-openstack-pull-requests
#412](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/412/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/139#issuecomment-54980196
[jclouds-labs-openstack-pull-requests
#411](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/411/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/139#issuecomment-54745331
[jclouds » jclouds-labs-openstack
#1690](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1690/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclo
> This still needs *Options naming changes, if any.
Would you rather wait for that discussion, or commit this and then make any
*Options changes (which will affect not only Neutron, I think?) in a separate
PR?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jcl
Checkstyle violations seem to have been fixed.
This still needs *Options naming changes, if any.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/139#issuecomment-54661390
[jclouds-labs-openstack-pull-requests
#409](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/409/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/139#issuecomment-54655650
[jclouds-labs-openstack-pull-requests
#408](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/408/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/139#issuecomment-54650942
Thanks for the changes, @zack-shoylev! Still a couple of [Checkstyle
violations](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/405/violations/),
by the way...but they don't seem to be related to this PR..?
---
Reply to this email directly or view it on GitHub:
https:/
> @@ -40,7 +40,7 @@ public String toString() {
>return name;
> }
>
> - /**
> was OK here, so why the change?
Originally my review comment, @jdaggett ;-) I made it because this seems like a
comment for a jclouds-dev, not something a **user** of jclouds would expect in
the Javadoc
Thanks @jdaggett !
I will be sitting on this one for a bit to figure out if we want to rename
createOptions/updateOptions.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/139#issuecomment-54509797
@jdaggett let me know if my comments answer your questions or if there is
anything else. Thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/139#issuecomment-54480981
[jclouds-labs-openstack-pull-requests
#405](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/405/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/139#issuecomment-54482376
[jclouds » jclouds-labs-openstack
#1674](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1674/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclo
>
> - Rule newSecGroupRule = null;
> - for(Rule sgr : securityGroup.getRules()) {
> -if(sgr.getId().equals(rule.getId())) {
> - newSecGroupRule = sgr;
> - break;
> -}
> - }
> - assertNotNull(newSecGroupRule, "Did
> @@ -40,7 +40,7 @@ public String toString() {
>return name;
> }
>
> - /**
Internal to jclouds?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/139/files#r17068569
Most of these changes were based on comments here:
https://github.com/jclouds/jclouds-labs-openstack/pull/132
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/139#issuecomment-54340665
There are other instances where `/**` changed to `/*` and if you could revert
those changes that would be awesome! +1 once the changes and other comments
have been addressed.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/139#issuec
>
> - Rule newSecGroupRule = null;
> - for(Rule sgr : securityGroup.getRules()) {
> -if(sgr.getId().equals(rule.getId())) {
> - newSecGroupRule = sgr;
> - break;
> -}
> - }
> - assertNotNull(newSecGroupRule, "Did
> @@ -18,8 +18,8 @@
> package org.jclouds.openstack.neutron.v2.domain;
>
> /**
> - * Enumerates supported Network types.
> - *
> + * Enumerates supported Network types.
> + *
> * @see*
> "http://docs.openstack.org/api/openstack-network/2.0/content/provider_ext.html";>api
> doc
N
> @@ -40,7 +40,7 @@ public String toString() {
>return name;
> }
>
> - /**
`/**` was OK here, so why the change?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/139/files#r17063974
> @@ -38,7 +38,7 @@ public String toString() {
>return name();
> }
>
> - /**
> + /*
Same as above!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/139/files#r17063978
[jclouds-labs-openstack-pull-requests
#403](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/403/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/139#issuecomment-54329013
[jclouds » jclouds-labs-openstack
#1665](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1665/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclo
I still have to figure out if we want to do something about *Options to
distinguish from the old patterns.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/139#issuecomment-54326965
You can merge this Pull Request by running:
git pull https://github.com/rackerlabs/jclouds-labs-openstack
neutron-small-cleanup
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs-openstack/pull/139
-- Commit Summary --
* Cleans up neutron cod
31 matches
Mail list logo
