I think I have addressed most of the issues around this PR and created new ones
in https://github.com/jclouds/jclouds-labs-openstack/pull/179
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/178#issuecomment-77446637
@@ -90,6 +90,7 @@
dependency
groupIdcom.google.auto.value/groupId
artifactIdauto-value/artifactId
+ version1.0-SNAPSHOT/version
The builders are in 1.1 which is what we need to make this beautiful. As
autovalue builders are also the way to go forward, this seems to
@@ -90,6 +90,7 @@
dependency
groupIdcom.google.auto.value/groupId
artifactIdauto-value/artifactId
+ version1.0-SNAPSHOT/version
But autovalue is not included as a dependency anyways - just the generated
code. As long as the generated code passes the tests, I see no
@@ -90,6 +90,7 @@
dependency
groupIdcom.google.auto.value/groupId
artifactIdauto-value/artifactId
+ version1.0-SNAPSHOT/version
auto-value released 1.0 recently:
http://repo1.maven.org/maven2/com/google/auto/value/auto-value/
Or do we need features only included in
@@ -90,6 +90,7 @@
dependency
groupIdcom.google.auto.value/groupId
artifactIdauto-value/artifactId
+ version1.0-SNAPSHOT/version
We have to be *very* careful about this, and I wouldn't merge this PR until
there is a release of auto with the builder support. Take into
I've just looked at the model classes and this is really cool and very clean!
Just one minor, according to the auto docs, you could add a non-static method
that returns the Builder (typically toBuilder()) and auto will mplement it and
populate the builder with the current values. It's just one
I have a small counter-argument about the toBuilder that I have been struggling
with:
You have 2 types of domain objects: write and read. For example:
Flavor flavor = api.list().first(); // -- Only generated by parsing service
gson
vs
api.create(CreateFlavor.builder().name(2).build()); // --
This PR is intended to get feedback from the community on the new builder
support. It does _not_ include live tests.
- Introduces `AutoValue.Builder` support to jclouds
- Adds `Service` and related domain objects
- Adds Poppy `ServiceApi` create and get methods
- Adds `ServiceApiMockTest`
/cc
