merged
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/111#issuecomment-50206106
Closed #111.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/111#event-145797651
[jclouds-labs-openstack-pull-requests
#335](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/335/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/111#issuecomment-50203344
[jclouds » jclouds-labs-openstack
#1470](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1470/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclo
Rebased, waiting for tests.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/111#issuecomment-50201944
About to rebase and get it ready for merge.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/111#issuecomment-50201613
+1 to the changes we discussed yesterday. Rebase/squash and let's push it!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/111#issuecomment-50200988
[jclouds-labs-openstack-pull-requests
#334](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/334/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/111#issuecomment-50189676
[jclouds » jclouds-labs-openstack
#1469](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1469/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclo
[jclouds-labs-openstack-pull-requests
#332](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/332/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/111#issuecomment-50082693
[jclouds » jclouds-labs-openstack
#1462](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1462/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclo
> +import java.io.Closeable;
> +import java.util.Set;
> +
> +/**
> + * Provides synchronous access to Neutron.
> + *
> + *
> + * @see href="http://docs.openstack.org/api/openstack-network/2.0/content/";>api
> doc
> + */
> +public interface NeutronApi extends Closeable {
> + /**
> +* @retur
> +import java.io.Closeable;
> +import java.util.Set;
> +
> +/**
> + * Provides synchronous access to Neutron.
> + *
> + *
> + * @see href="http://docs.openstack.org/api/openstack-network/2.0/content/";>api
> doc
> + */
> +public interface NeutronApi extends Closeable {
> + /**
> +* @retur
> +import java.io.Closeable;
> +import java.util.Set;
> +
> +/**
> + * Provides synchronous access to Neutron.
> + *
> + *
> + * @see href="http://docs.openstack.org/api/openstack-network/2.0/content/";>api
> doc
> + */
> +public interface NeutronApi extends Closeable {
> + /**
> +* @retur
I will be rebasing and merging later today or tomorrow in preparation for next
week's release, unless there are other comments.
Unless critical, such might have to be addressed in further PRs (this one is
big enough as it is).
---
Reply to this email directly or view it on GitHub:
https://github
[jclouds-labs-openstack-pull-requests
#329](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/329/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/111#issuecomment-50058851
[jclouds » jclouds-labs-openstack
#1457](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1457/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclo
Based on the documentation I am pretty sure that /v2.0/ is not part of what is
returned by the endpoint - for whatever reason.
For example, the current specs
https://wiki.openstack.org/wiki/Neutron/APIv2-specification
have all requests explicitly with the version in the path.
---
Reply to this e
> + * http://www.apache.org/licenses/LICENSE-2.0
> + *
> + * Unless required by applicable law or agreed to in writing, software
> + * distributed under the License is distributed on an "AS IS" BASIS,
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> + * See the L
> + return dnsNameServers;
> + }
> +
> + /**
> +* @return Configurable maximum amount of routes per subnet. The default
> is 20.
> +*/
> + @Nullable
> + public Set getHostRoutes() {
> + return hostRoutes;
> + }
> +
> + /**
> +* @return The IP v6 Address Mode.
> +
> +
> + Exception exception = message != null ? new
> HttpResponseException(command, response, message)
> +: new HttpResponseException(command, response);
> + message = message != null ? message : String.format("%s -> %s",
> command.getCurrentRequest().getRequestLine(),
> +
> + @SelectJson("router")
> + @Fallback(Fallbacks.NullOnNotFoundOr404.class)
> + @Nullable
> + Router update(@PathParam("id") String id, @WrapWith("router")
> Router.UpdateOptions router);
> +
> + /**
> +* Deletes the specified router
> +*
> +* @param id the id of the router
> +import javax.ws.rs.PUT;
> +import javax.ws.rs.Path;
> +import javax.ws.rs.PathParam;
> +import javax.ws.rs.core.MediaType;
> +
> +/**
> + * Provides synchronous access to Router operations on the OpenStack Neutron
> API.
> + *
> + * A logical entity for forwarding packets across internal subne
@zack-shoylev Just a couple of nits here and there, but its looking great! If
you could:
- run all of the JSON resources through [JSONLint](jsonlint.org).
- determine if the endpoint needs the `v2.0` in the service catalog and update
all references.
... that would be awesome. Thx!
---
Reply to
> +{
> +
> "publicURL":"URL/v2/da0d12be20394afb851716e10a49e4a7",
> +"id":"2122bcaa704343c19ad2578410d4961d",
> +
> "internalURL":"URL/v2/da0d12be20394afb851716e10a49e4a7",
> +"region
> + * http://www.apache.org/licenses/LICENSE-2.0
> + *
> + * Unless required by applicable law or agreed to in writing, software
> + * distributed under the License is distributed on an "AS IS" BASIS,
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> + * See the L
> @@ -0,0 +1,66 @@
> +/**
Is this class even necessary if we are using MWS tests?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/111/files#r15359627
> + }
> +
> + for(Subnet subnet : subnetApi.list().concat().toList()) {
> +subnetApi.delete(subnet.getId());
> + }
> +
> + for(Port port : portApi.list().concat().toList()) {
> +portApi.delete(port.getId());
> + }
> +
> + for(N
> + }
> +
> + for(Subnet subnet : subnetApi.list().concat().toList()) {
> +subnetApi.delete(subnet.getId());
> + }
> +
> + for(Port port : portApi.list().concat().toList()) {
> +portApi.delete(port.getId());
> + }
> +
> + for(N
> @@ -63,7 +64,7 @@ public static Properties defaultProperties() {
>
>protected Builder() {
> super(NeutronApi.class);
> - id("openstack-neutron")
> + id("openstack-neutron-legacy")
:+1: legacy
---
Reply to this email directly or view it on GitHub:
https://gith
> +
> + Exception exception = message != null ? new
> HttpResponseException(command, response, message)
> +: new HttpResponseException(command, response);
> + message = message != null ? message : String.format("%s -> %s",
> command.getCurrentRequest().getRequestLine(),
> +
> +
> + /**
> +* @return the Builder for creating a new Router
> +*/
> + public static CreateBuilder createOptions(String name) {
> + return new CreateBuilder(name);
> + }
> +
> + /**
> +* @return the Builder for updating a Router
> +*/
> + public static UpdateBuilder
> + @SelectJson("router")
> + @Fallback(Fallbacks.NullOnNotFoundOr404.class)
> + @Nullable
> + Router update(@PathParam("id") String id, @WrapWith("router")
> Router.UpdateOptions router);
> +
> + /**
> +* Deletes the specified router
> +*
> +* @param id the id of the router
> + @Named("router:removeInterfaceForSubnet")
> + @PUT
> + @Path("/{id}/remove_router_interface")
> + @MapBinder(EmptyOptions.class)
> + @Fallback(Fallbacks.FalseOnNotFoundOr404.class)
> + boolean removeInterfaceForSubnet(@PathParam("id") String routerId,
> @PayloadParam("subnet_id") S
> + @Path("/{id}/add_router_interface")
> + @MapBinder(EmptyOptions.class)
> + @Fallback(Fallbacks.NullOnNotFoundOr404.class)
> + @Nullable
> + RouterInterface addInterfaceForSubnet(@PathParam("id") String routerId,
> @PayloadParam("subnet_id") String subnetId);
> +
> + /**
> +* Ad
> +import javax.ws.rs.PUT;
> +import javax.ws.rs.Path;
> +import javax.ws.rs.PathParam;
> +import javax.ws.rs.core.MediaType;
> +
> +/**
> + * Provides synchronous access to Router operations on the OpenStack Neutron
> API.
> + *
> + * A logical entity for forwarding packets across internal subne
> +import java.io.Closeable;
> +import java.util.Set;
> +
> +/**
> + * Provides synchronous access to Neutron.
> + *
> + *
> + * @see href="http://docs.openstack.org/api/openstack-network/2.0/content/";>api
> doc
> + */
> +public interface NeutronApi extends Closeable {
> + /**
> +* @retur
> +
> + /**
> +* @return the Builder for creating a new Router
> +*/
> + public static CreateBuilder createOptions(String name) {
> + return new CreateBuilder(name);
> + }
> +
> + /**
> +* @return the Builder for updating a Router
> +*/
> + public static UpdateBuilder
> + return dnsNameServers;
> + }
> +
> + /**
> +* @return Configurable maximum amount of routes per subnet. The default
> is 20.
> +*/
> + @Nullable
> + public Set getHostRoutes() {
> + return hostRoutes;
> + }
> +
> + /**
> +* @return The IP v6 Address Mode.
> +
> +
> + /**
> +* @return the Builder for creating a new Router
> +*/
> + public static CreateBuilder createOptions(String name) {
> + return new CreateBuilder(name);
> + }
> +
> + /**
> +* @return the Builder for updating a Router
> +*/
> + public static UpdateBuilder
> + * doc
> + */
> +public class Network {
> +
> + private String id;
> + private NetworkStatus status;
> + private Set subnets;
> +
> + private String name;
> + @Named("admin_state_up")
> + private Boolean adminStateUp;
> + private Boolean shared;
> + @Named("tenant_id")
> +
> +import java.io.Closeable;
> +import java.util.Set;
> +
> +/**
> + * Provides synchronous access to Neutron.
> + *
> + *
> + * @see href="http://docs.openstack.org/api/openstack-network/2.0/content/";>api
> doc
> + */
> +public interface NeutronApi extends Closeable {
> + /**
> +* @retur
The documentation for this will probably keep getting updated. But this should
make it in 1.8.
Note: examples will have to be updated/created.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/111#issuecomment-49950900
[jclouds-labs-openstack-pull-requests
#327](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/327/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/111#issuecomment-49950911
> + * under the License.
> + */
> +package org.jclouds.openstack.neutron.v2.domain;
> +
> +import com.google.common.base.Objects;
> +import com.google.gson.annotations.SerializedName;
> +
> +import java.beans.ConstructorProperties;
> +
> +import static com.google.common.base.Preconditions.checkNotN
> + public static Properties defaultProperties() {
> + Properties properties = BaseHttpApiMetadata.defaultProperties();
> + properties.setProperty(SERVICE_TYPE, ServiceType.NETWORK);
> + properties.setProperty(CREDENTIAL_TYPE,
> CredentialTypes.PASSWORD_CREDENTIALS);
> + retu
> + * under the License.
> + */
> +package org.jclouds.openstack.neutron.v2.domain;
> +
> +import com.google.common.base.Objects;
> +import com.google.gson.annotations.SerializedName;
> +
> +import java.beans.ConstructorProperties;
> +
> +import static com.google.common.base.Preconditions.checkNotN
That's what I did previously (use the admin account).
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/111#issuecomment-49755250
@everett-toews Seems like a good start. I spent some time trying to figure out
if some of that can be automated during testing, but didn't look too promising.
My other idea is trying to use an admin account during testing.
---
Reply to this email directly or view it on GitHub:
https://github.com
@zack-shoylev @jdaggett @ccustine
I started a new wiki page [OpenStack
Testing](https://wiki.apache.org/jclouds/Testing%20OpenStack) to capture the
how-to info you provided Zack. Let's continue to expand on it.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jc
[jclouds » jclouds-labs-openstack
#1434](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1434/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclo
[jclouds-labs-openstack-pull-requests
#325](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/325/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/111#issuecomment-49392398
Rebased. Should be ready for another round of reviews. Fully featured.
Some suggestions:
1. Use @Beta ? Yes/no?
2. More documentation. Challange: A lot of the new stuff has little to no
documentation in the API docs.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclo
[jclouds » jclouds-labs-openstack
#1433](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1433/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclo
[jclouds-labs-openstack-pull-requests
#324](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/324/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/111#issuecomment-49391952
Alright, live tests now pass as well!
However, testing on devstack-icehouse, the following changes have to be made to
the neutron policy.json (/opt/stack/neutron/etc/policy.json):
1. create_network:router:external
2. get_network:provider:network_type
3. create_network:provider:network_type
4. up
[jclouds-labs-openstack-pull-requests
#323](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/323/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/111#issuecomment-49378815
[jclouds » jclouds-labs-openstack
#1432](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1432/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclo
[jclouds-labs-openstack-pull-requests
#322](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/322/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/111#issuecomment-49374819
[jclouds » jclouds-labs-openstack
#1431](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1431/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclo
[jclouds » jclouds-labs-openstack
#1430](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1430/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclo
[jclouds-labs-openstack-pull-requests
#321](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/321/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/111#issuecomment-49372397
[jclouds » jclouds-labs-openstack
#1429](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1429/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclo
[jclouds-labs-openstack-pull-requests
#320](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/320/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/111#issuecomment-49370128
[jclouds-labs-openstack-pull-requests
#318](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/318/)
FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/11
[jclouds » jclouds-labs-openstack
#1424](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1424/)
FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
Swift seems to be failing. But still works on my machine. I suspect maybe this
branch needs a rebase.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/111#issuecomment-49259625
Closed #111.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/111#event-142494359
Reopened #111.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/111#event-142494361
[jclouds-labs-openstack-pull-requests
#317](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/317/)
FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/11
[jclouds » jclouds-labs-openstack
#1423](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1423/)
FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
Closed #111.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/111#event-142465951
Reopened #111.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/111#event-142465954
[jclouds-labs-openstack-pull-requests
#316](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/316/)
FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/11
[jclouds » jclouds-labs-openstack
#1421](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1421/)
FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
[jclouds-labs-openstack-pull-requests
#314](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/314/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/111#issuecomment-49241692
[jclouds » jclouds-labs-openstack
#1418](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1418/)
FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
[jclouds-labs-openstack-pull-requests
#312](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/312/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/111#issuecomment-49105670
[jclouds » jclouds-labs-openstack
#1408](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1408/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclo
[jclouds-labs-openstack-pull-requests
#310](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/310/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/111#issuecomment-48980938
[jclouds » jclouds-labs-openstack
#1403](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1403/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclo
[jclouds-labs-openstack-pull-requests
#309](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/309/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/111#issuecomment-48666588
[jclouds » jclouds-labs-openstack
#1395](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1395/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclo
[jclouds » jclouds-labs-openstack
#1394](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1394/)
FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
[jclouds-labs-openstack-pull-requests
#308](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/308/)
FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/11
> +
> +import com.google.common.base.Objects;
> +
> +/**
> + * A Neutron Subnet Allocation Pool
> + *
> + * @see + *
> href="http://docs.openstack.org/api/openstack-network/2.0/content/Subnets.html";>api
> + * doc
> + */
> +public class AllocationPool {
> +
> + protected final String
Thanks so much for having a look!
ReturnNullOn404 - this needs to be fixed (I am pretty sure service does not
return it, but still double checking some sources)
@ConstructorProperties - based on previous discussions, I will add it back to
domain classes. The plan is to rework those to follow the
I had this PR in the bottom of the TODO list, sorry for my late reply!
I like the new pattern you propose. The model and the APIs look cleaner. The
code look good to me, just a couple comments:
* There are several POST requests that have the "ReturnNullOn404" fallback.
Does the service really r
> + @GET
> + @Path("/{id}")
> + @ResponseParser(ParseRouters.class)
> + @Fallback(EmptyRoutersFallback.class)
> + Routers get(@PathParam("id") String id);
> +
> + /**
> +* Create a new router
> +*
> +* @param router Options for creating a router
> +* @return the newly cr
> + @SerializedName("n1kv:segment_add")
> + protected final String segmentAdd;
> + @SerializedName("n1kv:segment_del")
> + protected final String segmentDel;
> + @SerializedName("n1kv:member_segments")
> + protected final String memberSegments;
> +
> + // multiprovidernet.py: Multipro
> +
> +import com.google.common.base.Objects;
> +
> +/**
> + * A Neutron Subnet Allocation Pool
> + *
> + * @see + *
> href="http://docs.openstack.org/api/openstack-network/2.0/content/Subnets.html";>api
> + * doc
> + */
> +public class AllocationPool {
> +
> + protected final String
@nacx Can you give this another look? Thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/111#issuecomment-48395860
[jclouds-labs-openstack-pull-requests
#304](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/304/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/111#issuecomment-4784
[jclouds » jclouds-labs-openstack
#1365](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1365/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclo
Hi reviewers!
There were a number of concerns with how the domain objects were implemented in
the old neutron and some different concerns with the refactored code.
Problems with the old code:
Options and Mapbinders (extra code, doesn't utilize GSON enough).
Newer code:
Create/Update/List objects
[jclouds-labs-openstack-pull-requests
#303](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/303/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/111#issuecomment-47837437
[jclouds » jclouds-labs-openstack
#1364](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1364/)
FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
[jclouds-labs-openstack-pull-requests
#301](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/301/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/111#issuecomment-47699884
[jclouds » jclouds-labs-openstack
#1353](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1353/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclo
[jclouds-labs-openstack-pull-requests
#298](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/298/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/111#issuecomment-47348972
1 - 100 of 147 matches
Mail list logo
