Closed #166.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/166#event-272752086
Thanks for the pull request but it's release week in jclouds and that means
it's time to clean up the PR queue. This PR will be over 6 months old as of
April 1. If you intend to continue work on it, please make a comment by April
2. Otherwise it will be closed on April 3.
---
Reply to this emai
@avibh Thanks for your patience, this is definitely progressing! As I
previously mentioned, we are moving to use AutoValue for value objects to
simplify development. Would you be up to making those changes in a follow on PR?
---
Reply to this email directly or view it on GitHub:
https://github.
> +package org.jclouds.openstack.ceilometer.v2;
> +
> +import org.jclouds.View;
> +import org.jclouds.apis.internal.BaseApiMetadataTest;
> +import org.testng.annotations.Test;
> +
> +import com.google.common.collect.ImmutableSet;
> +import com.google.common.reflect.TypeToken;
> +
> +/**
> + * Tests
> +import javax.ws.rs.Path;
> +import javax.ws.rs.Produces;
> +import javax.ws.rs.core.MediaType;
> +import java.util.List;
> +
> +
> +/**
> + * Provides access to Meters features.
> + *
> + */
> +@RequestFilters(AuthenticateRequest.class)
> +@Consumes(MediaType.APPLICATION_JSON)
> +@Path("/v2/quer
> +import javax.inject.Named;
> +import javax.ws.rs.Consumes;
> +import javax.ws.rs.POST;
> +import javax.ws.rs.Path;
> +import javax.ws.rs.Produces;
> +import javax.ws.rs.core.MediaType;
> +import java.util.List;
> +
> +
> +/**
> + * Provides access to Meters features.
> + *
> + */
> +@RequestFilt
> + */
> +@RequestFilters(AuthenticateRequest.class)
> +@Consumes(MediaType.APPLICATION_JSON)
> +@Path("/v2/meters")
> +public interface MeterApi {
> +
> + @Named("resource:listMeters")
> + @GET
> + @Fallback(EmptyListOnNotFoundOr404.class)
> + List list();
> +
> + @Named("resource:listMe
> +import javax.inject.Named;
> +import javax.ws.rs.Consumes;
> +import javax.ws.rs.GET;
> +import javax.ws.rs.Path;
> +import javax.ws.rs.Produces;
> +import javax.ws.rs.core.MediaType;
> +import java.util.List;
> +
> +
> +/**
> + * Provides access to Meters features.
> + *
> + */
> +@RequestFilte
> +
> + if (options.getLimit() != null) {
> +map.put("limit", options.getLimit());
> + }
> +
> + if (!isNullOrEmptyString(options.getOrderBy())) {
> +map.put("orderby", options.getOrderBy());
> + }
> + }
> +
> + request.setPayload(gs
> +
> + if (!isNullOrEmptyString(options.getFilter())) {
> +map.put("filter", options.getFilter());
> + }
> +
> + if (options.getLimit() != null) {
> +map.put("limit", options.getLimit());
> + }
> +
> + if (!isNullOrEmptyString(options
> + protected Gson gson;
> +
> + @Inject
> + public BindQueryRequestPayload() {
> + gson = new GsonBuilder().disableHtmlEscaping().create();
> + }
> +
> + @Override
> + public R bindToRequest(R request, Map Object> postParams) {
> + Map map = Maps.newHashMap();
> +
> + C
ping @jdaggett , @everett-toews ?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/166#issuecomment-63495674
@jdaggett Good to go here?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/166#issuecomment-63423589
[jclouds » jclouds-labs-openstack
#1976](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1976/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclo
[jclouds-labs-openstack-pull-requests
#495](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/495/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/166#issuecomment-63219011
fixed merge confilicts
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/166#issuecomment-63218871
changed the MetersApi.listMeters to MetersApi.list but left the QueryOptions as
is cause of a new ComplexQueryOptions for QueryApi .
changed QueryApi so it uses ComplexQueryOptions and used MapBinder to controle
the post params.
waiting for further comments
---
Reply to this email directly or vi
[jclouds » jclouds-labs-openstack
#1946](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1946/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclo
[jclouds-labs-openstack-pull-requests
#476](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/476/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/166#issuecomment-61772901
Hi @jdaggett
I've managed to overcome most of the issues using the following signature
MeterApi.listMeters(QueryOptions... options)
where QueryOptions is extending the BaseHttpRequestOptions class.
i'm now left with the following -
meters and samples can get query params, problem is they cant be
OK @avibh! Let's help answer the 3 questions you posed earlier. The Ceilometer
API started following some practices that we see in the Neutron APIs today.
Specifically filters, queries, and sorting of results. We need to address this
by augment `PaginationOptions` and potentially add some option
[jclouds » jclouds-labs-openstack
#1925](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1925/)
FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
[jclouds-labs-openstack-pull-requests
#473](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/473/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/166#issuecomment-60793542
[jclouds » jclouds-labs-openstack
#1923](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1923/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclo
[jclouds-labs-openstack-pull-requests
#472](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/472/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/166#issuecomment-60788674
[jclouds » jclouds-labs-openstack
#1922](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1922/)
UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
[jclouds-labs-openstack-pull-requests
#471](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/471/)
UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/1
Thanks for the review @jdaggett , I've applied the changes (except for the cool
@AutoValue feature).
any idea on the open issues I've wrote on the PR?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/166#issuecomment-60751524
> + public int hashCode() {
> + return Objects.hashCode(userId, name, resourceId, source, meterId,
> projectId, type, unit);
> + }
> +
> + protected Objects.ToStringHelper string() {
> + return Objects.toStringHelper(this)
> +.add("userId", userId).add("name", name).add
> +
> +/**
> + * Provides access to the OpenStack Orchestration (Heat) API.
> + *
> + */
> +public interface CeilometerApi extends Closeable {
> +
> + @Provides
> + @Region
> + Set getConfiguredRegions();
> +
> + /**
> +* Provides access to Meters features.
> +*/
> + @Delegate
> +
> + .credentialName("${password}")
> +
> .documentation(URI.create("https://wiki.openstack.org/wiki/Ceilometer";))
> + .version("2")
> + .endpointName("Keystone base url ending in /v2.0/")
> + .defaultEndpoint("http://localhost:5000/v2.0/";)
> +
> .
> +jclouds components to access an implementation of OpenStack
> Ceilometer
> +bundle
> +
> +
> +
> +
> http://localhost:5000/v2.0/
> +
> 1
> +
> +
> FIXME_IDENTITY
> +
> FIXME_CREDENTIALS
> +
> passwordCredentials
> +
> o
> +import java.util.Set;
> +
> +import org.jclouds.location.Region;
> +import org.jclouds.location.functions.RegionToEndpoint;
> +import org.jclouds.openstack.ceilometer.v2.features.MetersApi;
> +import org.jclouds.openstack.ceilometer.v2.features.QueryApi;
> +import org.jclouds.rest.annotations.De
Thanks for the contribution @avibh! I am going to start reviewing this PR this
afternoon.
I am not sure if you are aware of some changes being made to greatly simplify
development of new APIs/providers in jclouds with a library called AutoValue.
Since we are in a bit of flux there, I would re
[jclouds » jclouds-labs-openstack
#1909](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1909/)
FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
[jclouds-labs-openstack-pull-requests
#470](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/470/)
FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/16
[jclouds » jclouds-labs-openstack
#1908](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1908/)
UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
[jclouds-labs-openstack-pull-requests
#469](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/469/)
UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/1
OpenStack Ceilometer API's support (Skeleton & meters/samples API)
open issues I need help with -
1. meters and samples can get query params, problem is they cant be sent as
null/empty string since ceilometer fails. example - {"filter":
"", "orderby": "", "limit":
""}
need a way to avoid sendi
39 matches
Mail list logo
