> Are we good to merge that now?
Yes, fine by me. Thanks for the ping!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/122#issuecomment-69847462
Go to
http://1fe31db7584901aebe8a-dae5426beae6a9fc68a207722950803e.r58.cf5.rackcdn.com/
to review your changes.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/122#issuecomment-69715050
@demobox I've addressed your questions. Are we good to merge that now?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/122#issuecomment-69715798
> @@ -25,6 +25,7 @@ This involves [dockerizing an SSH daemon
> service](https://docs.docker.com/exampl
> // get a context with docker that offers the portable ComputeService api
> ComputeServiceContext context = ContextBuilder.newBuilder("docker")
>.credentials(email, pas
@andreaturli Another quick ping here..?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/122#issuecomment-59678682
@andreaturli Quick ping about the review comments?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/122#issuecomment-58405083
> @@ -25,6 +25,7 @@ This involves [dockerizing an SSH daemon
> service](https://docs.docker.com/exampl
> // get a context with docker that offers the portable ComputeService api
> ComputeServiceContext context = ContextBuilder.newBuilder("docker")
>.credentials(email, pas
Minor questions, but also +1 from me. Thanks, @andreaturli!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/122#issuecomment-51663073
> @@ -40,5 +41,7 @@ Set nodes =
> client.runNodesInGroup("container", 2, templ
> context.close();
> {% endhighlight %}
>
> +This assumes that `your-docker-engine-host` has docker remote API enabled
> over tcp.
"has the Docker remote API enabled over TCP."? And is there a link to the
"remote
The change lgtm. If no one has something to add, wanna commit and publish the
site?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/122#issuecomment-51591974
Go to
http://821c7ab8eeb61932c275-206a980fbfd6d40536d0e99c2209672a.r26.cf5.rackcdn.com/
to review your changes.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/122#issuecomment-51570368
[jclouds-site-pull-requests
#386](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/386/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/122#issuecomment-51570243
You can merge this Pull Request by running:
git pull https://github.com/andreaturli/jclouds-site patch-1
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-site/pull/122
-- Commit Summary --
* Update docker.md
-- File Changes --
M guides/dock
13 matches
Mail list logo