Re: [jclouds/jclouds-labs] add compute functions (#346)

2017-01-25 Thread Andrea Turli
Closed #346. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/346#event-936315783

Re: [jclouds/jclouds-labs] add compute functions (#346)

2017-01-25 Thread Andrea Turli
merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/a91ff3bd) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/346#issuecomment-275139640

Re: [jclouds/jclouds-labs] add compute functions (#346)

2017-01-25 Thread Andrea Turli
squashing and merging -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/346#issuecomment-275130509

Re: [jclouds/jclouds-labs] add compute functions (#346)

2017-01-25 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/346#pullrequestreview-18416045

Re: [jclouds/jclouds-labs] add compute functions (#346)

2017-01-25 Thread Andrea Turli
@andreaturli pushed 1 commit. fefb62e address @nacx comments -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/346/files/d186e2f5d3282cfb59aca10bd78aa9a8fa5795d6..fefb62e837e009843945763635a8c668b7ff3cb7

Re: [jclouds/jclouds-labs] add compute functions (#346)

2017-01-25 Thread Ignasi Barrera
nacx commented on this pull request. > + +private final JustProvider justProvider; + +// allow us to lazy discover the provider of a resource +@Inject +FacilityToLocation(JustProvider justProvider) { +this.justProvider = justProvider; +} + +@Override +public L

Re: [jclouds/jclouds-labs] add compute functions (#346)

2017-01-25 Thread Andrea Turli
andreaturli commented on this pull request. > + +private final JustProvider justProvider; + +// allow us to lazy discover the provider of a resource +@Inject +FacilityToLocation(JustProvider justProvider) { +this.justProvider = justProvider; +} + +@Override +p

Re: [jclouds/jclouds-labs] add compute functions (#346)

2017-01-25 Thread Ignasi Barrera
nacx commented on this pull request. > + +private final JustProvider justProvider; + +// allow us to lazy discover the provider of a resource +@Inject +FacilityToLocation(JustProvider justProvider) { +this.justProvider = justProvider; +} + +@Override +public L

Re: [jclouds/jclouds-labs] add compute functions (#346)

2017-01-25 Thread Andrea Turli
andreaturli commented on this pull request. > + +private final JustProvider justProvider; + +// allow us to lazy discover the provider of a resource +@Inject +FacilityToLocation(JustProvider justProvider) { +this.justProvider = justProvider; +} + +@Override +p

Re: [jclouds/jclouds-labs] add compute functions (#346)

2017-01-25 Thread Ignasi Barrera
nacx commented on this pull request. > + +@Resource +@Named(ComputeServiceConstants.COMPUTE_LOGGER) +protected Logger logger = Logger.NULL; + +private final PlanToHardware planToHardware; +private final OperatingSystemToImage operatingSystemToImage; +private final Facilit

Re: [jclouds/jclouds-labs] add compute functions (#346)

2017-01-24 Thread Andrea Turli
@andreaturli pushed 1 commit. 3825f9a improve DeviceToNodeMetadata -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/346/files/d1074295696a9bac88a3a6e9bb1c7581e295ae40..3825f9aea216c127fb948e586a2291c0177af269