@jbartece could you please review this and test if that fixes
https://issues.apache.org/jira/browse/JCLOUDS-900 ?
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/174
-- Commit Summary --
* support docker api v1.18
-- File
@heidsoft thanks for offering your help.
As the other jclouds provider you can run
mvn clean install -pLive -Dtest.docker.identity=public.pem
-Dtest.docker.credential=private.pem
-Dtest.docker.endpoint=https://your-docker-engine:2377
See also README for more details, and issue a PR to fix it
thanks @grkvlt ! I think it makes sense to have such a method. Probably it
should be the only mechanism supported *but* in order to do that we need to
improve the domain objects (moving to AutoValue for sure) so that they actually
support arbitrary fields.
Main problem is that DTO are quite
- fix reuse of existing storage service during deployment
- use AutoValue.Builder in DeployParams
- make network creation optional
- remove AzureComuteAdapterLiveTest b/c not meaningful
You can view, comment on, or merge this pull request online at:
@ilgrosso could you please have a look? thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/197#issuecomment-130598543
Closed #199.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/199#event-386424560
Merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/a058e9fc)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/199#issuecomment-132570668
thanks @kwart, lgtm!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/199#issuecomment-132566826
this is the current situation now:
```
Failed tests:
AzureComputeSecurityGroupExtensionLiveTestBaseSecurityGroupExtensionLiveTest.testAddIpPermission:145
ยป IllegalArgument
VMImageApiLiveTest.setup:97
RoleInstance{roleName=andrea253-vmimageapilivetest,
thanks @nacx
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/180#issuecomment-116490394
Merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/100bc250)
and backported to
[1.9.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/c55f6363)
---
Reply to this email directly or view it on GitHub:
thanks guys!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/785#issuecomment-116483970
Closed #785.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/785#event-342646348
Merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/61b06329) and
[1.9.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/0aad1387)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/785#issuecomment-116483908
thanks @nacx
Merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/100bc250)
and backported at
[1.9.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/c55f6363)
---
Reply to this email directly or view it on GitHub:
Closed #180.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/180#event-342652655
Closed #783.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/783#event-341132688
Merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/aa64e0d3) and
backported to
[1.9.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/4ac9a73d)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/783#issuecomment-115673949
+1, I'll address this comment and update
https://github.com/jclouds/jclouds-labs/pull/180 as well
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/785#issuecomment-115692075
@zack-shoylev could you please review it?
I'd like to merge that on master and 1.9.x if you think it is ok
LiveTests are ok for me, but `removeFirewallRuleFromPolicy` as it seems that
the
[doc](https://docs.google.com/document/d/1PJaKvsX2MzMRlLGfR0fBkrMraHYF0flvl0sqyZ704tA/edit#)
is not
+ @Named(firewall_policy_id)
+ private String firewallPolicyId;
+
+ @ConstructorProperties({id, tenant_id, name, description,
admin_state_up,
+ status, firewall_policy_id})
+ protected Firewall(String id, String tenantId, String name, String
description, boolean
+ FirewallRule createFirewallRule(@WrapWith(firewall_rule) FirewallRule
firewallRule);
+
+ @Named(firewall:listFirewallRules)
+ @GET
+ @Transform(FirewallRuleToPagedIterable.class)
+ @ResponseParser(ParseFirewallRules.class)
+ @Fallback(EmptyPagedIterableOnNotFoundOr404.class)
@@ -47,6 +48,10 @@ public void testCreateUpdateAndDeleteSecurityGroup() {
try {
sgApi = api.getSecurityGroupApi(region).get();
+for (Subnet subnet :
api.getSubnetApi(region).list().concat().toList()) {
+ System.out.println(subnet: +
Thanks @zack-shoylev
I've addressed your comments:
- I've added AutoValue for Firewall, FirewallPolicy and FirewallPolicyRule
- Add PaginatedCollection where possible
and some other minor fixes
Does it look better now?
---
Reply to this email directly or view it on GitHub:
@@ -272,7 +272,7 @@ public int compare(Hardware h1, Hardware h2) {
.compare(getBootableDeviceType(h1),
getBootableDeviceType(h2));
if (!volumes1.isEmpty() !volumes2.isEmpty()
volumes1.size() == volumes2.size()) {
I see your point, I will fix it later!
@@ -272,7 +272,7 @@ public int compare(Hardware h1, Hardware h2) {
.compare(getBootableDeviceType(h1),
getBootableDeviceType(h2));
if (!volumes1.isEmpty() !volumes2.isEmpty()
volumes1.size() == volumes2.size()) {
@andrewgaul thanks for the comment but
- fix VirtualGuestBlockDeviceTemplateGroupApiLiveTest
- fix SoftLayerComputeServiceLiveTest
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/838
-- Commit Summary --
* [SoftLayer] fix some failing LiveTests
-- File Changes --
M
thanks @nacx, comments addressed
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/838#issuecomment-129854249
Merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/1163b94c)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/838#issuecomment-129953297
backport to
[1.9.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/cc1217b5)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/838#issuecomment-129956125
Closed #838.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/838#event-379347047
- fix a typo
- add FWaaS extension for Neutron
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-site/pull/171
-- Commit Summary --
* Update 1.9.1.md
-- File Changes --
M releasenotes/1.9.1.md (123)
-- Patch Links --
@@ -105,10 +105,10 @@
final String location = template.getLocation().getId();
final int[] inboundPorts = template.getOptions().getInboundPorts();
- final String storageAccountName =
templateOptions.getStorageAccountName().get();
- final String virtualNetworkName =
@ilgrosso @nacx thanks for your reviews!
@nacx: re design concern: I changed the implementation to support the following
3 use-cases:
1. user-specified network name: jclouds checks its existence, otherwise
IllegalArgumentException
2. user doesn't provide a networkName: jclouds looks for a
@@ -44,7 +45,7 @@ public AzureComputeProviderMetadataLive() {
public static Properties defaultProperties() {
final Properties properties =
AzureManagementApiMetadata.defaultProperties();
- properties.setProperty(TEMPLATE,
Ok, let's support properly use-case 1. In order to use a specific virtual
network, the end user needs to specify the `virtualNetworkName` and 1-more
`subnetNames`, so let's keep those specific `AzureComputeTemplateOptions`.
---
Reply to this email directly or view it on GitHub:
@ilgrosso my last commit should fix a bunch of things, specifically
```
testAddIpPermission(org.jclouds.azurecompute.compute.extensions.AzureComputeSecurityGroupExtensionLiveTest)
testOptionToNotBlock(org.jclouds.azurecompute.compute.AzureComputeServiceLiveTest)
```
*but*
```
@ilgrosso and @nacx I've temporarily disabled a check in DiskLiveTest as I need
to study more the Azure API.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/197#issuecomment-131080487
@@ -44,7 +45,7 @@ public AzureComputeProviderMetadataLive() {
public static Properties defaultProperties() {
final Properties properties =
AzureManagementApiMetadata.defaultProperties();
- properties.setProperty(TEMPLATE,
+1 @nacx, thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/198#issuecomment-131030279
Really sorry @nacx, that file shouldn't be there, of course!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/823#issuecomment-124548617
rebuild please
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/823#issuecomment-124560152
thanks @nacx and @neykov! I'll merge it as also the builder looks happy!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/823#issuecomment-124588231
Merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/f5e1c476) and
[1.9.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/1863f859)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/823#issuecomment-124590806
Closed #823.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/823#event-364712372
This backports to 1.9.x a fix that was already done into master
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/191
-- Commit Summary --
* fix azure DataVirtualHardDiskHandler
-- File Changes --
M
thanks @nacx !
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/191#issuecomment-123744224
Merged at
[1.9.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/610f26de)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/191#issuecomment-123744412
Closed #191.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/191#event-362352048
unfortunately the failure is not related to this PR but to
https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/927/org.apache.jclouds.labs$jdbc/
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/221#issuecomment-155475255
I think #221 supercedes this PR. @jbartece can you please look at it and report
here, if #174 can be closed? Thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/174#issuecomment-155463815
Using the following versions
```
$ docker version
Client:
Version: 1.9.0
API version: 1.21
Go version: go1.4.3
Git commit: 76d6bc9
Built:Tue Nov 3 19:20:09 UTC 2015
OS/Arch: darwin/amd64
Server:
Version: 1.9.0
API version: 1.21
Go version: go1.4.3
Git
> + assertNotNull(network);
> + assertNotNull(network.id());
> +
> + }
> +
> + @Test(dependsOnMethods = "testCreateNetwork")
> + public void testGetNetwork() {
> + network = api().inspectNetwork(network.id());
> + assertNotNull(network);
> + }
> +
> +
> + container = api.getContainerApi().inspectContainer(container.id());
> + }
> +
> + @AfterClass
> + protected void tearDown() {
> + if (container != null) {
> + api.getContainerApi().stopContainer(container.id());
> +
> +
> + try {
> + api.removeNetwork(networkId);
> + assertSent(server, "DELETE", "/networks/" + networkId);
> +
> + } finally {
> + server.shutdown();
> + }
> + }
> +
> + public void testConnectContainerToNetwork() throws Exception {
> +
>}
>
>public Builder fromNetworkSettings(NetworkSettings in) {
> return
> this.ipAddress(in.ipAddress()).ipPrefixLen(in.ipPrefixLen()).gateway(in.gateway()).bridge(in.bridge())
> - .portMapping(in.portMapping()).ports(in.ports());
> +
>
> + public void testGetNetwork() {
> + network = api().inspectNetwork(network.id());
> + assertNotNull(network);
> + }
> +
> + @Test(dependsOnMethods = "testGetNetwork")
> + public void testAttachContainerToNetwork() {
> + api().connectContainerToNetwork(network.id(),
Thanks @nacx I think I'm done now, I hope :)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/221#issuecomment-155814158
Closed #221.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/221#event-463732998
Thanks @nacx !
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/174#issuecomment-155386385
thanks @nacx
backport to
[1.9.x](https://git1-us-west.apache.org/repos/asf?p=jclouds.git;a=commit;h=c6f2d846)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/827#issuecomment-148671800
@nacx it would be really useful to have it backported to 1.9.x
is it ok?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/827#issuecomment-148659573
@nacx not sure I get the purpose of this feature: the login port like any other
ports depends on the docker engine, specifically the network type, and it is
not a feature of an image. Am I missing something?
---
Reply to this email directly or view it on GitHub:
t;dr: I think I've fixed `AzureComputeServiceLiveTest#testListSizes` and
`AzureComputeServiceContextLiveTest#testLaunchNodes` as @ilgrosso was
suggesting.
Here the current situation for the entire `LiveTests` suite:
```
Tests run: 99, Failures: 3, Errors: 0, Skipped: 14, Time elapsed: 3,972.34
Thanks @ilgrosso
Do you think we can merge this PR if I fix
`AzureComputeServiceLiveTest#testListSizes` ?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/197#issuecomment-135748154
Thanks @googlielmo, lgtm
Waiting for builder to complete before merging
also
@demobox, @googlielmo has already filed the [Apache
ICLA](http://people.apache.org/committer-index.html#unlistedclas) so I think we
can merge his contribution, yes?
---
Reply to this email directly or view it on
thanks @zack-shoylev, I've added the comment to justify the case 500
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/860#issuecomment-142650280
> @@ -97,6 +97,13 @@ else if (message.indexOf("already exists") != -1)
> exception = new ResourceNotFoundException(message, exception);
> }
> break;
> +case 500:
it is part of the same fix, when floating IP are finished, openstack returns
500
Merged #173.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/173#event-416676505
Merged #134.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/134#event-416676077
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-site/pull/174
-- Commit Summary --
* add softlayer getting started
-- File Changes --
M guides/index.md (1)
A guides/softlayer.md (141)
M reference/providers.md (4)
-- Patch
Reverts jclouds/jclouds-site#134
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-site/pull/173
-- Commit Summary --
* Revert "add softlayer getting started"
-- File Changes --
M guides/index.md (1)
D guides/softlayer.md (144)
thanks @andrewgaul, I've removed the reference to the inputStream.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/174#issuecomment-142521744
I think we can merge it now, and address the comments on swift when it will be
removed. Thoughts?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/134#issuecomment-142332117
- improve destroyNode that could remove keypair and/or securityGroup if required
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/860
-- Commit Summary --
* improve roll-back strategy when floating-ip are not available
-- File Changes
Closed #207.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/207#event-426648432
@nacx, great!
Thanks @googlielmo for your patch! Keep up the great work!
Merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/a4b26323)
and [1.9.x](
http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/b199681d)
---
Reply to this email directly or view it on
Closed #890.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/890#event-489477134
Merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/75e2c699) and
[1.9.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/36358bcc)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/890#issuecomment-163970174
+1 @Graeme-Miller, great work!
meriging now
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/890#issuecomment-163964018
close as #221 fix the same issues and has been already merged.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/174#issuecomment-159644092
Closed #174.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/174#event-474640206
@ilgrosso yes indeed. The idea of this PR was not to fix all of the failing
live tests but to simplify the usage of the templateOptions and to make
virtualNetwork optional when provisioning a VM, I think.
I think we need to make sure that we can run those tests even in a
non-completely clean
@ritazh generally this means that jclouds couldn't ssh to the VM for the
following reasons:
```
- timeout: slow provisioning
- wrong password
- port 22 closed
```
could you identify a test case that is likely to show the problem more often?
---
You are receiving this because you are subscribed
Closed #170.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/170#event-682644994
ok cool! Merging now!
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/170#issuecomment-223916136
thanks @bostko
Merged at
[1.9.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs-google/commit/276ee07e)
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
> @@ -207,11 +207,11 @@ private void getImagesFromPublisher(String
> publisherName, List osImages
>
> private List listImagesByLocation(String location) {
>final List osImages = Lists.newArrayList();
> -
> - getImagesFromPublisher("Microsoft.WindowsAzure.Compute", osImages,
>
> @@ -207,7 +208,7 @@ private void getImagesFromPublisher(String publisherName,
> List osImages
>
> private List listImagesByLocation(String location) {
>final List osImages = Lists.newArrayList();
> - String[] publishers =
>
hi @ritazh, I'm trying to follow the
[README](https://github.com/jclouds/jclouds-labs/blob/8e7d4c057640151ebefbfbd3ef24de8be7a9171f/azurecompute-arm/README.md#run-live-tests)
to run the liveTests but I get this error:
```
java.lang.NullPointerException: test.jclouds.oauth.resource
at
> +
> + @Inject
> + VMHardwareToHardware(@Memoized final Supplier
> locations) {
> + this.locations = locations;
> + }
> +
> + @Override
> + public Hardware apply(VMHardware from) {
> + final HardwareBuilder builder = new HardwareBuilder()
> +
thx @duncangrant, merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/7e55ad79)
do you need to back-port this patch to 1.9.x branch as well? I think there are
conflicts when trying to cherry-pick the same commit.
---
You are receiving this because you are subscribed
Closed #277.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/277#event-682926168
lgtm, merging
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/277#issuecomment-223971079
> + public boolean apply(final String name) {
> +runningNumber++;
> +
> +Deployment deployment =
> api.getDeploymentApi(resourceGroupName).create(name, deploymentTemplate);
> +
> +if (deployment != null) {
> + VMDeployment vmDeployment =
> + public boolean apply(final String name) {
> +runningNumber++;
> +
> +Deployment deployment =
> api.getDeploymentApi(resourceGroupName).create(name, deploymentTemplate);
> +
> +if (deployment != null) {
> + VMDeployment vmDeployment =
Thanks @ritazh, just wondering, do you think this
`-Dtest.jclouds.oauth.resource="https://management.azure.com/` parameter is
likely to change? or it will be always the same? in that case, maybe we should
add it to the
ok backported at
[1.9.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/2033e639)
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/277#issuecomment-223978616
cool!
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/279#issuecomment-224316758
> +import static
> org.jclouds.azurecompute.arm.config.AzureComputeProperties.OPERATION_POLL_INITIAL_PERIOD;
> +import static
> org.jclouds.azurecompute.arm.config.AzureComputeProperties.OPERATION_POLL_MAX_PERIOD;
> +import static
>
301 - 400 of 1591 matches
Mail list logo
